Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ts-ignoring some stuff in tests #343

Merged
merged 3 commits into from
Nov 19, 2018
Merged

Conversation

alexander-fenster
Copy link
Contributor

These lines in test cause tsc errors both locally and in gax system tests. No idea why/how it passes in Pub/Sub CI but anyway, let's @ts-ignore failing lines for now.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2018
@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2018
@codecov
Copy link

codecov bot commented Nov 19, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@11de938). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #343   +/-   ##
=========================================
  Coverage          ?   96.42%           
=========================================
  Files             ?       13           
  Lines             ?     1062           
  Branches          ?      144           
=========================================
  Hits              ?     1024           
  Misses            ?       32           
  Partials          ?        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11de938...0bd01ae. Read the comment docs.

@jkwlui
Copy link
Member

jkwlui commented Nov 19, 2018

Hi @alexander-fenster I made some changes so we don't have to resort to ts-ignore :)

@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2018
@alexander-fenster
Copy link
Contributor Author

Thanks @kinwa91! Can you please make a patch release when this PR lands?

@alexander-fenster
Copy link
Contributor Author

Note: samples test in Kokoro is flaky :(

@alexander-fenster alexander-fenster merged commit 695380e into master Nov 19, 2018
@alexander-fenster alexander-fenster deleted the fix-typescript branch November 19, 2018 23:17
@alexander-fenster
Copy link
Contributor Author

Merged - please use your release magic tool to draft a patch release to make gax system tests work! I have no idea how to do it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants