Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build): eslint all js files, and use js for all generated files #331

Merged
merged 4 commits into from
Nov 12, 2018
Merged

chore(build): eslint all js files, and use js for all generated files #331

merged 4 commits into from
Nov 12, 2018

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Cloning googleapis.
synthtool > Running generator for google/pubsub/artman_pubsub.yaml.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:229601142daed005bf56fbaa21a02cf7aa0b261b57677d38306f8013e536de7a
Status: Image is up to date for googleapis/artman:latest
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/pubsub-v1.
.circleci/config.yml
.circleci/npm-install-retry.js
.eslintignore
.eslintrc.yml
.github/CONTRIBUTING.md
.github/ISSUE_TEMPLATE/bug_report.md
.github/ISSUE_TEMPLATE/feature_request.md
.github/ISSUE_TEMPLATE/support_request.md
.jsdoc.js
.kokoro/common.cfg
.kokoro/continuous/node10/common.cfg
.kokoro/continuous/node10/test.cfg
.kokoro/continuous/node11/common.cfg
.kokoro/continuous/node11/test.cfg
.kokoro/continuous/node6/common.cfg
.kokoro/continuous/node6/test.cfg
.kokoro/continuous/node8/common.cfg
.kokoro/continuous/node8/docs.cfg
.kokoro/continuous/node8/lint.cfg
.kokoro/continuous/node8/samples-test.cfg
.kokoro/continuous/node8/system-test.cfg
.kokoro/continuous/node8/test.cfg
.kokoro/docs.sh
.kokoro/lint.sh
.kokoro/presubmit/node10/common.cfg
.kokoro/presubmit/node10/test.cfg
.kokoro/presubmit/node11/common.cfg
.kokoro/presubmit/node11/test.cfg
.kokoro/presubmit/node6/common.cfg
.kokoro/presubmit/node6/test.cfg
.kokoro/presubmit/node8/common.cfg
.kokoro/presubmit/node8/docs.cfg
.kokoro/presubmit/node8/lint.cfg
.kokoro/presubmit/node8/samples-test.cfg
.kokoro/presubmit/node8/system-test.cfg
.kokoro/presubmit/node8/test.cfg
.kokoro/presubmit/windows/common.cfg
.kokoro/presubmit/windows/test.cfg
.kokoro/samples-test.sh
.kokoro/system-test.sh
.kokoro/test.bat
.kokoro/test.sh
.kokoro/trampoline.sh
.nycrc
CODE_OF_CONDUCT.md
codecov.yaml
synthtool > Replaced '  }\n\\s*/\\*\\*\n\\s+\\* The DNS address for this API service.' in src/v1/subscriber_client.js.
synthtool > Replaced '../../package.json' in src/v1/publisher_client.js.
synthtool > Replaced '../../package.json' in src/v1/subscriber_client.js.
npm WARN deprecated text-encoding@0.6.4: no longer maintained
npm WARN deprecated circular-json@0.3.3: CircularJSON is in maintenance only, flatted is its successor.

> grpc@1.16.0 install /tmpfs/src/git/autosynth/working_repo/node_modules/grpc
> node-pre-gyp install --fallback-to-build --library=static_library

node-pre-gyp WARN Using request for node-pre-gyp https download 
[grpc] Success: "/tmpfs/src/git/autosynth/working_repo/node_modules/grpc/src/node/extension_binary/node-v57-linux-x64-glibc/grpc_node.node" is installed via remote

> protobufjs@6.8.8 postinstall /tmpfs/src/git/autosynth/working_repo/node_modules/protobufjs
> node scripts/postinstall


> @google-cloud/pubsub@0.20.1 prepare /tmpfs/src/git/autosynth/working_repo
> npm run compile


> @google-cloud/pubsub@0.20.1 compile /tmpfs/src/git/autosynth/working_repo
> tsc -p . && cp -r src/v1/ build/src/v1/ && cp -r protos build/

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN gts@0.8.0 requires a peer of typescript@^2.7.1 but none is installed. You must install peer dependencies yourself.
npm WARN acorn-jsx@5.0.0 requires a peer of acorn@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.4 (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.4: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 1192 packages from 1322 contributors and audited 7766 packages in 27.489s
found 0 vulnerabilities


> @google-cloud/pubsub@0.20.1 fix /tmpfs/src/git/autosynth/working_repo
> eslint --fix 'samples/*.js' 'samples/**/*.js'


/tmpfs/src/git/autosynth/working_repo/samples/quickstart.js
  20:26  error  "@google-cloud/pubsub" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/subscriptions.js
   29:28  error  "@google-cloud/pubsub" is not found  node/no-missing-require
   45:28  error  "@google-cloud/pubsub" is not found  node/no-missing-require
   66:28  error  "@google-cloud/pubsub" is not found  node/no-missing-require
   92:28  error  "@google-cloud/pubsub" is not found  node/no-missing-require
  133:28  error  "@google-cloud/pubsub" is not found  node/no-missing-require
  161:28  error  "@google-cloud/pubsub" is not found  node/no-missing-require
  190:28  error  "@google-cloud/pubsub" is not found  node/no-missing-require
  209:28  error  "@google-cloud/pubsub" is not found  node/no-missing-require
  231:28  error  "@google-cloud/pubsub" is not found  node/no-missing-require
  271:26  error  "@google-cloud/pubsub" is not found  node/no-missing-require
  370:28  error  "@google-cloud/pubsub" is not found  node/no-missing-require
  429:28  error  "@google-cloud/pubsub" is not found  node/no-missing-require
  472:28  error  "@google-cloud/pubsub" is not found  node/no-missing-require
  492:28  error  "@google-cloud/pubsub" is not found  node/no-missing-require
  530:28  error  "@google-cloud/pubsub" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/topics.js
   29:28  error  "@google-cloud/pubsub" is not found  node/no-missing-require
   44:28  error  "@google-cloud/pubsub" is not found  node/no-missing-require
   64:28  error  "@google-cloud/pubsub" is not found  node/no-missing-require
   85:28  error  "@google-cloud/pubsub" is not found  node/no-missing-require
  112:28  error  "@google-cloud/pubsub" is not found  node/no-missing-require
  148:28  error  "@google-cloud/pubsub" is not found  node/no-missing-require
  191:28  error  "@google-cloud/pubsub" is not found  node/no-missing-require
  225:28  error  "@google-cloud/pubsub" is not found  node/no-missing-require
  245:28  error  "@google-cloud/pubsub" is not found  node/no-missing-require
  283:28  error  "@google-cloud/pubsub" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/system-test/subscriptions.test.js
  19:26  error  "@google-cloud/pubsub" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/system-test/topics.test.js
  19:26  error  "@google-cloud/pubsub" is not found  node/no-missing-require

✖ 28 problems (28 errors, 0 warnings)

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @google-cloud/pubsub@0.20.1 fix: `eslint --fix 'samples/*.js' 'samples/**/*.js'`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @google-cloud/pubsub@0.20.1 fix script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/kbuilder/.npm/_logs/2018-11-12T12_14_35_755Z-debug.log
synthtool > Cleaned up 2 temporary directories.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 12, 2018
@codecov
Copy link

codecov bot commented Nov 12, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@e2444d9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #331   +/-   ##
=========================================
  Coverage          ?   96.39%           
=========================================
  Files             ?       13           
  Lines             ?     1053           
  Branches          ?      143           
=========================================
  Hits              ?     1015           
  Misses            ?       32           
  Partials          ?        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2444d9...346621f. Read the comment docs.

@JustinBeckwith JustinBeckwith changed the title [CHANGE ME] Re-generated to pick up changes in the API or client library generator. chore(build): eslint all js files, and use js for all generated files Nov 12, 2018
@JustinBeckwith JustinBeckwith merged commit f50b95d into master Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yoshi-automation @JustinBeckwith @googlebot