Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ts): enable noImplicitThis #316

Merged
merged 7 commits into from
Nov 5, 2018
Merged

refactor(ts): enable noImplicitThis #316

merged 7 commits into from
Nov 5, 2018

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Nov 3, 2018

Fixes #312

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 3, 2018
@JustinBeckwith JustinBeckwith requested a review from a team November 3, 2018 05:13
@codecov
Copy link

codecov bot commented Nov 3, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@6c74961). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #316   +/-   ##
========================================
  Coverage          ?   96.4%           
========================================
  Files             ?      13           
  Lines             ?    1058           
  Branches          ?     142           
========================================
  Hits              ?    1020           
  Misses            ?      32           
  Partials          ?       6
Impacted Files Coverage Δ
src/index.ts 100% <100%> (ø)
src/snapshot.ts 100% <100%> (ø)
src/topic.ts 98.66% <100%> (ø)
src/subscription.ts 99.07% <100%> (ø)
src/iam.ts 100% <100%> (ø)
src/subscriber.ts 98.7% <100%> (ø)
src/histogram.ts 100% <100%> (ø)
src/publisher.ts 98.03% <100%> (ø)
src/connection-pool.ts 99.44% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c74961...94b2b5f. Read the comment docs.

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 3, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 3, 2018
@JustinBeckwith JustinBeckwith merged commit bb357fc into googleapis:master Nov 5, 2018
@JustinBeckwith JustinBeckwith deleted the noImplicitThis branch February 4, 2019 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants