Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update tests to reflect upstream fix #448

Merged
merged 1 commit into from
Jan 31, 2023
Merged

test: update tests to reflect upstream fix #448

merged 1 commit into from
Jan 31, 2023

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Jan 31, 2023

The upstream behaviour in protobufjs was changed to throw an error rather than return null:

See: protobufjs/protobuf.js#1817

@bcoe bcoe requested a review from a team as a code owner January 31, 2023 16:41
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants