Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use walkdir instead of globby #109

Merged
merged 2 commits into from
Nov 9, 2018
Merged

refactor: use walkdir instead of globby #109

merged 2 commits into from
Nov 9, 2018

Conversation

JustinBeckwith
Copy link
Contributor

Should have a ~120ms reduction in module load time.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 9, 2018
Copy link

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Hopefully a follow-on can return a Promise of files rather than doing sync work. Who uses this feature anyway? Is the caching actually worth it?

@JustinBeckwith
Copy link
Contributor Author

I have no idea my friend. I don't have a good handle on what this library does vs gax. I will however follow up with an async version after this all propagates without incident. It's very core, so I'm scared to change a ton at once.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@9a23d42). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #109   +/-   ##
=========================================
  Coverage          ?   91.54%           
=========================================
  Files             ?        6           
  Lines             ?      201           
  Branches          ?        6           
=========================================
  Hits              ?      184           
  Misses            ?       17           
  Partials          ?        0
Impacted Files Coverage Δ
src/load.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a23d42...e168a1e. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 7849ea3 into googleapis:master Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants