Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(middleware): use common code from logging #197

Merged
merged 4 commits into from
Nov 9, 2018

Conversation

ofrobots
Copy link
Contributor

@ofrobots ofrobots commented Nov 8, 2018

Start using refactored code from @g-c/logging.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2018
@ofrobots ofrobots added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 8, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 8, 2018
@ofrobots ofrobots requested a review from kjin November 8, 2018 19:11
Copy link
Contributor

@kjin kjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

package.json Outdated Show resolved Hide resolved
@ofrobots ofrobots merged commit 5ab8724 into googleapis:master Nov 9, 2018
@ofrobots ofrobots deleted the use-make-middleware branch November 9, 2018 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants