Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pegging GRPC version to 1.7.1 #86

Merged
merged 1 commit into from
Dec 19, 2017
Merged

Pegging GRPC version to 1.7.1 #86

merged 1 commit into from
Dec 19, 2017

Conversation

schmidt-sebastian
Copy link
Contributor

GRPC 1.8.0 seems to cause 'Stream Removed' Errors on Firebase Functions: grpc/grpc-node#130

@ghost ghost added the cla: yes This human has signed the Contributor License Agreement. label Dec 19, 2017
@codecov
Copy link

codecov bot commented Dec 19, 2017 •
edited
Loading

Codecov Report

Merging #86 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #86   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        1599   1599           
=====================================
  Hits         1599   1599

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc3898...7a3020d. Read the comment docs.

@schmidt-sebastian schmidt-sebastian changed the title Pegging GRPC version at 1.7.1 Pegging GRPC version to 1.7.1 Dec 19, 2017
lukesneeringer
lukesneeringer reviewed Dec 19, 2017
View reviewed changes
package.json
@@ -56,7 +56,7 @@
"extend": "^3.0.1",
"functional-red-black-tree": "^1.0.1",
"google-gax": "^0.14.1",
"grpc": "^1.6.0",
"grpc": "1.7.1",

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@schmidt-sebastian schmidt-sebastian merged commit 9f8642f into master Dec 19, 2017
@ghost ghost removed the cla: yes This human has signed the Contributor License Agreement. label Dec 19, 2017
@callmehiphop
Copy link
Contributor

Did using 1.7.x resolve this for you? We're seeing the same error in Spanner, however it doesn't use 1.8, it's been using 1.7 the whole time.

@schmidt-sebastian
Copy link
Contributor Author

Did using 1.7.x resolve this for you? We're seeing the same error in Spanner, however it doesn't use 1.8, it's been using 1.7 the whole time.

Preparing to revert this PR after confirming that this issue exists in 1.7.1.

schmidt-sebastian added a commit that referenced this pull request Dec 19, 2017
@schmidt-sebastian
Revert "Pegging GRPC version at 1.7.1 (#86)"
6cb643f 
This reverts commit 9f8642f.
@schmidt-sebastian schmidt-sebastian mentioned this pull request Dec 19, 2017
Closed
@schmidt-sebastian schmidt-sebastian deleted the grpc160 branch January 30, 2018 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukesneeringer lukesneeringer lukesneeringer left review comments

@stephenplusplus stephenplusplus stephenplusplus approved these changes

Assignees

@stephenplusplus stephenplusplus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schmidt-sebastian @callmehiphop @lukesneeringer @stephenplusplus