Including previous data when we encounter a transform #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
schmidt-sebastian
force-pushed
the
mrschmidt-nonemptymap
branch
from
eebe10e to
ff333a5
Compare
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 1648 1648
=====================================
Hits 1648 1648
Continue to review full report at Codecov.
|
|
LGTM. Looks like I'm not part of the org yet though. |
gsoltis
approved these changes
Jan 29, 2018
ghost
removed
the
cla: yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes firebase/firebase-admin-node#191
When we compute the merge document from an update call, we cannot just skip all leaf paths that include document transforms. We need to retain any existing data that may already be available at this path.