refactor(samples): convert sample tests from ava to mocha #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
JustinBeckwith
suggested changes
Nov 15, 2018
…/nodejs-error-reporting into sample_ava_to_mocha
…/nodejs-error-reporting into sample_ava_to_mocha
JustinBeckwith
approved these changes
Nov 19, 2018
JustinBeckwith
added
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #257 +/- ##
=======================================
Coverage 88.47% 88.47%
=======================================
Files 29 29
Lines 1241 1241
Branches 151 151
=======================================
Hits 1098 1098
Misses 87 87
Partials 56 56Continue to review full report at Codecov.
|
nareshqlogic
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
Hi @JustinBeckwith , |
JustinBeckwith
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes convert all sample tests from ava to mocha #2865 (it's a good idea to open an issue first for discussion)