Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use strictEqual in tests #140

Merged
merged 1 commit into from
Jul 18, 2018
Merged

test: use strictEqual in tests #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions test/gapic-v1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ describe('DatastoreClient', () => {

client.lookup(request, (err, response) => {
assert(err instanceof Error);
assert.equal(err.code, FAKE_STATUS_CODE);
assert.strictEqual(err.code, FAKE_STATUS_CODE);
assert(typeof response === 'undefined');
done();
});
Expand Down Expand Up @@ -134,7 +134,7 @@ describe('DatastoreClient', () => {

client.runQuery(request, (err, response) => {
assert(err instanceof Error);
assert.equal(err.code, FAKE_STATUS_CODE);
assert.strictEqual(err.code, FAKE_STATUS_CODE);
assert(typeof response === 'undefined');
done();
});
Expand Down Expand Up @@ -194,7 +194,7 @@ describe('DatastoreClient', () => {

client.beginTransaction(request, (err, response) => {
assert(err instanceof Error);
assert.equal(err.code, FAKE_STATUS_CODE);
assert.strictEqual(err.code, FAKE_STATUS_CODE);
assert(typeof response === 'undefined');
done();
});
Expand Down Expand Up @@ -258,7 +258,7 @@ describe('DatastoreClient', () => {

client.commit(request, (err, response) => {
assert(err instanceof Error);
assert.equal(err.code, FAKE_STATUS_CODE);
assert.strictEqual(err.code, FAKE_STATUS_CODE);
assert(typeof response === 'undefined');
done();
});
Expand Down Expand Up @@ -319,7 +319,7 @@ describe('DatastoreClient', () => {

client.rollback(request, (err, response) => {
assert(err instanceof Error);
assert.equal(err.code, FAKE_STATUS_CODE);
assert.strictEqual(err.code, FAKE_STATUS_CODE);
assert(typeof response === 'undefined');
done();
});
Expand Down Expand Up @@ -380,7 +380,7 @@ describe('DatastoreClient', () => {

client.allocateIds(request, (err, response) => {
assert(err instanceof Error);
assert.equal(err.code, FAKE_STATUS_CODE);
assert.strictEqual(err.code, FAKE_STATUS_CODE);
assert(typeof response === 'undefined');
done();
});
Expand Down Expand Up @@ -441,7 +441,7 @@ describe('DatastoreClient', () => {

client.reserveIds(request, (err, response) => {
assert(err instanceof Error);
assert.equal(err.code, FAKE_STATUS_CODE);
assert.strictEqual(err.code, FAKE_STATUS_CODE);
assert(typeof response === 'undefined');
done();
});
Expand Down
66 changes: 33 additions & 33 deletions test/query.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ describe('Query', function() {
var query = new Query(['kind1']).filter('date', '<=', now);
var filter = query.filters[0];

assert.equal(filter.name, 'date');
assert.equal(filter.op, '<=');
assert.equal(filter.val, now);
assert.strictEqual(filter.name, 'date');
assert.strictEqual(filter.op, '<=');
assert.strictEqual(filter.val, now);
});

it('should recognize all the different operators', function() {
Expand All @@ -76,37 +76,37 @@ describe('Query', function() {
.filter('size', '<', 10)
.filter('something', '>=', 11);

assert.equal(query.filters[0].name, 'date');
assert.equal(query.filters[0].op, '<=');
assert.strictEqual(query.filters[0].name, 'date');
assert.strictEqual(query.filters[0].op, '<=');
assert.strictEqual(query.filters[0].val, now);

assert.equal(query.filters[1].name, 'name');
assert.equal(query.filters[1].op, '=');
assert.equal(query.filters[1].val, 'Title');
assert.strictEqual(query.filters[1].name, 'name');
assert.strictEqual(query.filters[1].op, '=');
assert.strictEqual(query.filters[1].val, 'Title');

assert.equal(query.filters[2].name, 'count');
assert.equal(query.filters[2].op, '>');
assert.strictEqual(query.filters[2].name, 'count');
assert.strictEqual(query.filters[2].op, '>');
assert.strictEqual(query.filters[2].val, 20);

assert.equal(query.filters[3].name, 'size');
assert.equal(query.filters[3].op, '<');
assert.strictEqual(query.filters[3].name, 'size');
assert.strictEqual(query.filters[3].op, '<');
assert.strictEqual(query.filters[3].val, 10);

assert.equal(query.filters[4].name, 'something');
assert.equal(query.filters[4].op, '>=');
assert.strictEqual(query.filters[4].name, 'something');
assert.strictEqual(query.filters[4].op, '>=');
assert.strictEqual(query.filters[4].val, 11);
});

it('should remove any whitespace surrounding the filter name', function() {
var query = new Query(['kind1']).filter(' count ', '>', 123);

assert.equal(query.filters[0].name, 'count');
assert.strictEqual(query.filters[0].name, 'count');
});

it('should remove any whitespace surrounding the operator', function() {
var query = new Query(['kind1']).filter('count', ' < ', 123);

assert.equal(query.filters[0].op, '<');
assert.strictEqual(query.filters[0].op, '<');
});

it('should return the query instance', function() {
Expand All @@ -120,18 +120,18 @@ describe('Query', function() {
var query = new Query(['kind1']).filter('name', 'Stephen');
var filter = query.filters[0];

assert.equal(filter.name, 'name');
assert.equal(filter.op, '=');
assert.equal(filter.val, 'Stephen');
assert.strictEqual(filter.name, 'name');
assert.strictEqual(filter.op, '=');
assert.strictEqual(filter.val, 'Stephen');
});
});

describe('hasAncestor', function() {
it('should support ancestor filtering', function() {
var query = new Query(['kind1']).hasAncestor(['kind2', 123]);

assert.equal(query.filters[0].name, '__key__');
assert.equal(query.filters[0].op, 'HAS_ANCESTOR');
assert.strictEqual(query.filters[0].name, '__key__');
assert.strictEqual(query.filters[0].op, 'HAS_ANCESTOR');
assert.deepEqual(query.filters[0].val, ['kind2', 123]);
});

Expand All @@ -147,33 +147,33 @@ describe('Query', function() {
it('should default ordering to ascending', function() {
var query = new Query(['kind1']).order('name');

assert.equal(query.orders[0].name, 'name');
assert.equal(query.orders[0].sign, '+');
assert.strictEqual(query.orders[0].name, 'name');
assert.strictEqual(query.orders[0].sign, '+');
});

it('should support ascending order', function() {
var query = new Query(['kind1']).order('name');

assert.equal(query.orders[0].name, 'name');
assert.equal(query.orders[0].sign, '+');
assert.strictEqual(query.orders[0].name, 'name');
assert.strictEqual(query.orders[0].sign, '+');
});

it('should support descending order', function() {
var query = new Query(['kind1']).order('count', {descending: true});

assert.equal(query.orders[0].name, 'count');
assert.equal(query.orders[0].sign, '-');
assert.strictEqual(query.orders[0].name, 'count');
assert.strictEqual(query.orders[0].sign, '-');
});

it('should support both ascending and descending', function() {
var query = new Query(['kind1'])
.order('name')
.order('count', {descending: true});

assert.equal(query.orders[0].name, 'name');
assert.equal(query.orders[0].sign, '+');
assert.equal(query.orders[1].name, 'count');
assert.equal(query.orders[1].sign, '-');
assert.strictEqual(query.orders[0].name, 'name');
assert.strictEqual(query.orders[0].sign, '+');
assert.strictEqual(query.orders[1].name, 'count');
assert.strictEqual(query.orders[1].sign, '-');
});

it('should return the query instance', function() {
Expand Down Expand Up @@ -230,7 +230,7 @@ describe('Query', function() {
it('should capture the starting cursor value', function() {
var query = new Query(['kind1']).start('X');

assert.equal(query.startVal, 'X');
assert.strictEqual(query.startVal, 'X');
});

it('should return the query instance', function() {
Expand All @@ -245,7 +245,7 @@ describe('Query', function() {
it('should capture the ending cursor value', function() {
var query = new Query(['kind1']).end('Z');

assert.equal(query.endVal, 'Z');
assert.strictEqual(query.endVal, 'Z');
});

it('should return the query instance', function() {
Expand Down
8 changes: 4 additions & 4 deletions test/request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,7 @@ describe('Request', function() {

it('should multi delete by keys', function(done) {
request.request_ = function(config, callback) {
assert.equal(config.reqOpts.mutations.length, 2);
assert.strictEqual(config.reqOpts.mutations.length, 2);
callback();
};
request.delete([key, key], done);
Expand Down Expand Up @@ -1285,7 +1285,7 @@ describe('Request', function() {

it('should save with specific method', function(done) {
request.request_ = function(config, callback) {
assert.equal(config.reqOpts.mutations.length, 3);
assert.strictEqual(config.reqOpts.mutations.length, 3);
assert(is.object(config.reqOpts.mutations[0].insert));
assert(is.object(config.reqOpts.mutations[1].update));
assert(is.object(config.reqOpts.mutations[2].upsert));
Expand Down Expand Up @@ -1481,8 +1481,8 @@ describe('Request', function() {
data: [{name: 'name', value: 'value'}],
});

assert.equal(typeof request.requestCallbacks_[0], 'function');
assert.equal(typeof request.requests_[0], 'object');
assert.strictEqual(typeof request.requestCallbacks_[0], 'function');
assert.strictEqual(typeof request.requests_[0], 'object');
});
});
});
Expand Down
26 changes: 13 additions & 13 deletions test/transaction.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,8 @@ describe('Transaction', function() {

it('should commit', function(done) {
transaction.request_ = function(config) {
assert.equal(config.client, 'DatastoreClient');
assert.equal(config.method, 'commit');
assert.strictEqual(config.client, 'DatastoreClient');
assert.strictEqual(config.method, 'commit');
assert.strictEqual(config.gaxOptions, undefined);
done();
};
Expand Down Expand Up @@ -255,10 +255,10 @@ describe('Transaction', function() {

transaction.commit();

assert.equal(deleteCalled, 1);
assert.equal(saveCalled, 1);
assert.strictEqual(deleteCalled, 1);
assert.strictEqual(saveCalled, 1);

assert.equal(args.length, 2);
assert.strictEqual(args.length, 2);

// Save arguments must come first.
assert.deepEqual(args, [[saveArg1, saveArg2], [deleteArg1, deleteArg2]]);
Expand All @@ -282,8 +282,8 @@ describe('Transaction', function() {
transaction.request_ = util.noop;

transaction.commit();
assert.equal(deleteCalled, 0);
assert.equal(saveCalled, 1);
assert.strictEqual(deleteCalled, 0);
assert.strictEqual(saveCalled, 1);
});

it('should not squash key-incomplete mutations', function(done) {
Expand Down Expand Up @@ -373,10 +373,10 @@ describe('Transaction', function() {

transaction.delete(keys);

assert.equal(transaction.modifiedEntities_.length, keys.length);
assert.strictEqual(transaction.modifiedEntities_.length, keys.length);

transaction.modifiedEntities_.forEach(function(queuedEntity) {
assert.equal(queuedEntity.method, 'delete');
assert.strictEqual(queuedEntity.method, 'delete');
assert(keys.indexOf(queuedEntity.entity.key) > -1);
assert.deepEqual(queuedEntity.args, [queuedEntity.entity.key]);
});
Expand All @@ -391,7 +391,7 @@ describe('Transaction', function() {
it('should rollback', function(done) {
transaction.request_ = function(config) {
assert.strictEqual(config.client, 'DatastoreClient');
assert.equal(config.method, 'rollback');
assert.strictEqual(config.method, 'rollback');
assert.strictEqual(config.gaxOptions, undefined);
done();
};
Expand Down Expand Up @@ -590,7 +590,7 @@ describe('Transaction', function() {

transaction.run(function(err) {
assert.ifError(err);
assert.equal(transaction.id, TRANSACTION_ID);
assert.strictEqual(transaction.id, TRANSACTION_ID);
done();
});
});
Expand All @@ -616,10 +616,10 @@ describe('Transaction', function() {

transaction.save(entities);

assert.equal(transaction.modifiedEntities_.length, entities.length);
assert.strictEqual(transaction.modifiedEntities_.length, entities.length);

transaction.modifiedEntities_.forEach(function(queuedEntity) {
assert.equal(queuedEntity.method, 'save');
assert.strictEqual(queuedEntity.method, 'save');

var match = entities.filter(function(ent) {
return ent.key === queuedEntity.entity.key;
Expand Down