Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop support for node.js 4.x and 9.x #129

Merged
merged 2 commits into from
Jul 10, 2018
Merged

fix: drop support for node.js 4.x and 9.x #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac5018d
fix: drop support for node.js 4.x and 9.x
JustinBeckwith Jul 10, 2018
06f4d56
Merge branch 'master' into no-moar-4
JustinBeckwith Jul 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 7 additions & 29 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,14 @@ workflows:
filters: *all_commits
- lint:
requires:
- node4
- node6
- node8
- node9
- node10
filters: *all_commits
- docs:
requires:
- node4
- node6
- node8
- node9
- node10
filters: *all_commits
- system_tests:
Expand Down Expand Up @@ -62,9 +58,9 @@ workflows:
only: master
jobs: *workflow_jobs
jobs:
node4:
node6:
docker:
- image: 'node:4'
- image: 'node:6'
user: node
steps: &unit_tests_steps
- checkout
Expand All @@ -86,28 +82,14 @@ jobs:
npm install
environment:
NPM_CONFIG_PREFIX: /home/node/.npm-global
- run:
name: Run unit tests.
command: npm test
- run:
name: Submit coverage data to codecov.
command: node_modules/.bin/codecov
when: always
node6:
docker:
- image: 'node:6'
user: node
steps: *unit_tests_steps
- run: npm test
- run: node_modules/.bin/codecov

node8:
docker:
- image: 'node:8'
user: node
steps: *unit_tests_steps
node9:
docker:
- image: 'node:9'
user: node
steps: *unit_tests_steps
node10:
docker:
- image: 'node:10'
Expand Down Expand Up @@ -202,9 +184,5 @@ jobs:
user: node
steps:
- checkout
- run:
name: Set NPM authentication.
command: 'echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ~/.npmrc'
- run:
name: Publish the module to npm.
command: npm publish
- run: 'echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ~/.npmrc'
- run: npm publish
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"license": "Apache-2.0",
"author": "Google Inc.",
"engines": {
"node": ">=4.0.0"
"node": ">=6.0.0"
},
"repository": "googleapis/nodejs-datastore",
"main": "./src/index.js",
Expand Down