test: Add retries to increase reliability of test #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test needs to be skipped as it is causing P1 issues to appear. We need a formal plan for reproducing this issue.
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
bot
added
size: xs
This block of code is an after hook that will not work anymore now that the test is skipped because the test creates an instance and the after hook tries to delete it
kolea2
suggested changes
Aug 22, 2023
system-test/read-rows.ts
Outdated
| @@ -85,7 +85,7 @@ describe('Bigtable/Table', () => { | |||
| const TABLE = INSTANCE.table('table'); | |||
|
|
|||
| describe('close', () => { | |||
| it('should fail when invoking readRows with closed client', async () => { | |||
| it.skip('should fail when invoking readRows with closed client', async () => { | |||
There was a problem hiding this comment.
can we add retries to this test instead? I would prefer not to skip it, unless it is consistently failing (in which case we should investigate an alternate solution there too).
There was a problem hiding this comment.
Yes. I added a change which will still allow the test to run and retry in the appropriate circumstances.
Add retry options to create table to ensure that there is enough time for the instance to get created in order to avoid flakey tests
product-auto-label
bot
added
size: s
danieljbruce
changed the title
danieljbruce
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
kolea2
approved these changes
Oct 23, 2023
danieljbruce
added a commit
to danieljbruce/nodejs-bigtable
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds retries to the create table function in a test in order to reduce the risk of a flakey test in the case where the table cannot be created. This will solve some of the flakey test issues that we have been having.
Fixes #1292
Fixes #1291