-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing error code to RowError #11
Conversation
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
@kolodny I went ahead and made a commit for unit tests, if it looks good to you I'll merge this asap. |
Looks good to me! |
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 8 8
Lines 791 792 +1
=====================================
+ Hits 791 792 +1
Continue to review full report at Codecov.
|
Fixes #5
There was a missing err.code assignment that was missing in RowError, Family has a similar snippet.
Also added tests around the
row.exists()
method.