Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing error code to RowError #11

Merged
merged 3 commits into from
Nov 14, 2017

Conversation

kolodny
Copy link
Contributor

@kolodny kolodny commented Nov 14, 2017

Fixes #5

There was a missing err.code assignment that was missing in RowError, Family has a similar snippet.

Also added tests around the row.exists() method.

@ghost ghost assigned kolodny Nov 14, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 14, 2017
@kolodny kolodny requested a review from jmdobry November 14, 2017 03:37
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@ghost ghost assigned callmehiphop Nov 14, 2017
@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 14, 2017
@callmehiphop
Copy link
Contributor

@kolodny I went ahead and made a commit for unit tests, if it looks good to you I'll merge this asap.

@jmdobry jmdobry removed their request for review November 14, 2017 20:37
@kolodny
Copy link
Contributor Author

kolodny commented Nov 14, 2017

Looks good to me!

@ghost ghost added the cla: yes This human has signed the Contributor License Agreement. label Nov 14, 2017
@codecov-io
Copy link

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #11   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      8           
  Lines         791    792    +1     
=====================================
+ Hits          791    792    +1
Impacted Files Coverage Δ
src/table.js 100% <ø> (ø) ⬆️
src/row.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76336af...c303953. Read the comment docs.

@callmehiphop callmehiphop merged commit 0ae96ed into googleapis:master Nov 14, 2017
@ghost ghost removed the cla: yes This human has signed the Contributor License Agreement. label Nov 14, 2017
@stephenplusplus stephenplusplus mentioned this pull request Dec 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants