This repository has been archived by the owner on Nov 14, 2023. It is now read-only.
automl: tables-related snippet cleanup #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #392 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 7 7
Lines 9654 9654
Branches 375 375
=======================================
Hits 9536 9536
Misses 114 114
Partials 4 4 Continue to review full report at Codecov.
|
bcoe
approved these changes
Apr 28, 2020
|
@bcoe - how long do these Samples/System test checks typically take? It'd be nice to wrap up this by EOW. |
bcoe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
@Strykrol apologies missed your last note, unfortunately I think someone needs to throw the |
bcoe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These samples are being removed as part of internal clean-up to reduce unnecessary clutter of samples repos. These specific code samples/region tags are not in any localized docs nor on CGC.
This PR is in progress (still working on fixing up tests), but I've opened this for review in case these samples need to be retained for reasons I'm not aware of. If so, alternative option(s) could include simply removing region tagging.