feat: Add mcp transport protocol #345
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twishabansal
changed the title
twishabansal
force-pushed
the
mcp-transport-implement
branch
from
7e58222 to
78014d7
Compare
twishabansal
changed the base branch from
mcp-restructure
to
client-transport-decouple
twishabansal
changed the base branch from
client-transport-decouple
to
mcp-restructure
twishabansal
force-pushed
the
mcp-transport-implement
branch
from
0d87f13 to
83030dc
Compare
twishabansal
changed the base branch from
mcp-restructure
to
client-transport-decouple
|
/gcbrun |
anubhav756
approved these changes
Sep 4, 2025
kurtisvg
requested changes
Oct 3, 2025
There was a problem hiding this comment.
At a high level, I'm concerned with the type safety of this approach. Given we have such concrete types defined by MCP, we should be re-implementing those for each version and ensuring requests and responses match them correctly. As is, this method seems difficult to scale as MCP evolves over time.
An example of what this should look like is probably more then like protocol.py is defined here.
| ) | ||
|
|
||
|
|
||
| class McpHttpTransport(ITransport): |
There was a problem hiding this comment.
Shouldn't there be a different transport for each supported MCP version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the MCP protocol does not yet support Auth related functionality such as
Authorized InvocationsandAuthenticated Parameters.Therefore, the default is still the Toolbox Protocol here.
Note: This PR is currently based on two separate PRs. The protocol is added in #348. This will be updated once the protocol object PR is merged.