-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create(Blob) instrumentation #2792
Open
sydney-munro
wants to merge
5
commits into
otel-v1-branch
Choose a base branch
from
otel-it-testing
base: otel-v1-branch
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
Pull request size is large.
api: storage
Issues related to the googleapis/java-storage API.
labels
Oct 24, 2024
sydney-munro
force-pushed
the
otel-it-testing
branch
from
October 24, 2024 21:59
8cc3a2b
to
3856854
Compare
sydney-munro
changed the title
wip create(Blob) instrumentation
feat: wip create(Blob) instrumentation
Oct 24, 2024
sydney-munro
force-pushed
the
otel-it-testing
branch
from
October 24, 2024 22:26
9efdd37
to
8fe835b
Compare
frankyn
reviewed
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still reviewing adding one question; I see it's WIP; are you ready for review?
google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageImpl.java
Show resolved
Hide resolved
not yet just testing some stuff out as the testbench integration is a pain to sort out locally. |
sydney-munro
commented
Oct 24, 2024
google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageImpl.java
Show resolved
Hide resolved
sydney-munro
force-pushed
the
otel-it-testing
branch
from
October 25, 2024 19:43
023a996
to
3543adf
Compare
sydney-munro
changed the title
feat: wip create(Blob) instrumentation
feat: create(Blob) instrumentation
Oct 25, 2024
sydney-munro
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: storage
Issues related to the googleapis/java-storage API.
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
size: l
Pull request size is large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.