Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create(Blob) instrumentation #2792

Open
wants to merge 5 commits into
base: otel-v1-branch
Choose a base branch
from
Open

feat: create(Blob) instrumentation #2792

wants to merge 5 commits into from

Conversation

sydney-munro
Copy link
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@sydney-munro sydney-munro requested a review from a team as a code owner October 24, 2024 20:48
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/java-storage API. labels Oct 24, 2024
@sydney-munro sydney-munro changed the title wip create(Blob) instrumentation feat: wip create(Blob) instrumentation Oct 24, 2024
frankyn
frankyn reviewed Oct 24, 2024
View reviewed changes
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still reviewing adding one question; I see it's WIP; are you ready for review?

google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageImpl.java Show resolved Hide resolved
@sydney-munro
Copy link
Collaborator Author

still reviewing adding one question; I see it's WIP; are you ready for review?

not yet just testing some stuff out as the testbench integration is a pain to sort out locally.

@sydney-munro sydney-munro marked this pull request as draft October 25, 2024 17:44
@sydney-munro sydney-munro marked this pull request as ready for review October 25, 2024 19:56
@sydney-munro sydney-munro changed the title feat: wip create(Blob) instrumentation feat: create(Blob) instrumentation Oct 25, 2024
@sydney-munro sydney-munro added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankyn frankyn Awaiting requested review from frankyn

@JesseLovelace JesseLovelace Awaiting requested review from JesseLovelace

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/java-storage API. kokoro:force-run Add this label to force Kokoro to re-run the tests. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sydney-munro @frankyn