Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Initial CLI for SSB integration #2166

Merged
merged 13 commits into from
Aug 23, 2023
Merged

feat: Initial CLI for SSB integration #2166

merged 13 commits into from
Aug 23, 2023

Conversation

sydney-munro
Copy link
Collaborator

No description provided.

@sydney-munro sydney-munro requested review from a team as code owners August 15, 2023 16:15
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/java-storage API. labels Aug 15, 2023
@sydney-munro sydney-munro marked this pull request as draft August 15, 2023 16:15
StorageOptions alwaysRetryStorageOptions =
StorageOptions.newBuilder().setProjectId(project).setRetrySettings(retrySettings).build();
Storage storageClient = alwaysRetryStorageOptions.getService();
Path tempDir = Paths.get(System.getProperty("java.io.tmpdir"));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want this to be an argument, sometimes java.io.tmpdir can be in a not so great place. (Not something that needs to change in this PR)

ssb/pom.xml Outdated Show resolved Hide resolved
ssb/pom.xml Outdated Show resolved Hide resolved
ssb/pom.xml Outdated Show resolved Hide resolved
@sydney-munro sydney-munro marked this pull request as ready for review August 17, 2023 14:33
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Aug 17, 2023
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Aug 17, 2023
@sydney-munro sydney-munro merged commit a349735 into main Aug 23, 2023
16 checks passed
@sydney-munro sydney-munro deleted the ssbcli branch August 23, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants