ci: compile in JDK 17 to run Java 8 unit tests [not for review] #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the compilation by JDK 17 generates Java 8-compatible bytecode.
|
Warning: This pull request is touching the following templated files:
|
product-auto-label
bot
added
the
api: storage
suztomo
changed the title
|
Next step: Why did "ci / units (8)" succeed? |
|
Finally it caught the dummy Java 8-incompatible code https://github.com/googleapis/java-storage/actions/runs/5337901838/jobs/9674553850?pr=2081 correctly:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the compilation by JDK 17 generates Java 8-compatible bytecode.
The file being modified is templated by OwlBot postprocessor. I'm running checks to confirm upcoming change in the template works good.
C.f., googleapis/java-spanner#2440