Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add internal data structures for transactional connection state #3321

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Commits on Sep 10, 2024

  1. refactor: add internal data structures for transactional connection s…

    …tate
    
    This change adds internal data structures that can be used for transactional
    connection state. These data structures also reduces the amount of code that
    is needed for each connection property that is added. Connection properties
    are currently represented as actual variables in the ConnectionImpl class.
    These new data structures removes the need for that.
    
    Only the connection property retryAbortsInternally is refactored to use
    the new data structure. All other connection properties will be refactored
    in a following change, in order to keep each change as small as possible.
    
    The data structure supports both transactional and non-transactional
    connection state. Transactional state is disabled in the current version
    in order to be consistent with the current behavior. It will be enabled
    in a later change when all connection properties have been refactored
    to use the new data structure.
    olavloite committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a7dd2e9 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. refactor: replace individual variables with ConnectionProperty (#3322)

    * refactor: add internal data structures for transactional connection state
    
    This change adds internal data structures that can be used for transactional
    connection state. These data structures also reduces the amount of code that
    is needed for each connection property that is added. Connection properties
    are currently represented as actual variables in the ConnectionImpl class.
    These new data structures removes the need for that.
    
    Only the connection property retryAbortsInternally is refactored to use
    the new data structure. All other connection properties will be refactored
    in a following change, in order to keep each change as small as possible.
    
    The data structure supports both transactional and non-transactional
    connection state. Transactional state is disabled in the current version
    in order to be consistent with the current behavior. It will be enabled
    in a later change when all connection properties have been refactored
    to use the new data structure.
    
    * refactor: replace individual variables with ConnectionProperty
    
    Replace individual variables in ConnectionOptions and ConnectionImpl with
    references to ConnectionProperties. This reduces the amount of code bloat,
    especially in ConnectionOptions, as all connection property parsing is
    now handled by the ConnectionState class in a generic way.
    
    This setup also reduces the amount of code that is needed to add a new
    connection property, as there is only one source of truth: the list of
    properties in the ConnectionProperties class.
    
    Following steps that will reduce the amount of code bloat further are:
    1. Replace all the regular expressions for SET and SHOW statements with
       a simple token-based parser.
    2. Cleaning up ConnectionOptions further by removing the duplicate list
       of ConnectionProperties there. These can be removed once the JDBC
       driver has been updated to use the new list of properties.
    olavloite committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    64eed59 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Configuration menu
    Copy the full SHA
    5f51a2a View commit details
    Browse the repository at this point in the history