Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: skip clirr 7012 exceptions with grpc admin package #3222

Merged
merged 1 commit into from
Jul 26, 2024
Merged

chore: skip clirr 7012 exceptions with grpc admin package #3222

merged 1 commit into from
Jul 26, 2024

Conversation

rahul2393
Copy link
Contributor

@rahul2393 rahul2393 commented Jul 23, 2024 •
edited
Loading

Fixes CLIRR failure in mainline https://github.com/googleapis/java-spanner/actions/runs/10050817564/job/27779375111

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@rahul2393 rahul2393 requested review from a team as code owners July 23, 2024 01:24
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels Jul 23, 2024
@olavloite olavloite merged commit 9de91d7 into main Jul 26, 2024
32 of 34 checks passed
@olavloite olavloite deleted the skip-clirr-checks branch July 26, 2024 08:20
@diegomarquezp diegomarquezp mentioned this pull request Aug 16, 2024
Open
@rahul2393 rahul2393 restored the skip-clirr-checks branch August 27, 2024 05:26
rahul2393 added a commit that referenced this pull request Aug 27, 2024
@rahul2393
chore: skip clirr 7012 exceptions with grpc admin package #3222
7cf8c39
@rahul2393 rahul2393 deleted the skip-clirr-checks branch August 27, 2024 05:27
rahul2393 added a commit that referenced this pull request Aug 27, 2024
@rahul2393
chore: skip clirr 7012 exceptions with grpc admin package #3222 (#3305)
eaa0853
lqiu96 pushed a commit that referenced this pull request Sep 10, 2024
@rahul2393 @lqiu96
chore: skip clirr 7012 exceptions with grpc admin package #3222 (#3305)
01683ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

@harshachinta harshachinta Awaiting requested review from harshachinta

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahul2393 @olavloite