fix: ignore UnsupportedOperationException for virtual threads #2866
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The virtual threads util that tries to create a virtual thread factory on JVMs that support this would fail on Java 20, because: 1. Java 20 supports virtual threads as an experimental feature. This means that the code is present. 2. The feature is by default disabled, and throws an UnsupportedOperationException. This fix takes the above into account and returns null if a user tries to create a virtual threads factory on Java 20 with experimental features disabled.
product-auto-label
bot
added
the
api: spanner
rahul2393
approved these changes
Feb 7, 2024
olavloite
added
automerge
yoshi-kokoro
removed
the
kokoro:force-run
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
surbhigarg92
approved these changes
Feb 7, 2024
gcf-merge-on-green
bot
deleted the
ignore-unsupported-operation-for-virtual-threads
branch
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The virtual threads util that tries to create a virtual thread factory on JVMs that support this would fail on Java 20, because:
This fix takes the above into account and returns null if a user tries to create a virtual threads factory on Java 20 with experimental features disabled.