-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use default query options with statement cache #2860
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 changes: 75 additions & 0 deletions
75
google-cloud-spanner/src/test/java/com/google/cloud/spanner/connection/QueryOptionsTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| /* | ||
| * Copyright 2024 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.google.cloud.spanner.connection; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
|
|
||
| import com.google.cloud.spanner.ResultSet; | ||
| import com.google.cloud.spanner.Statement; | ||
| import com.google.spanner.v1.ExecuteSqlRequest; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
| import org.junit.runners.JUnit4; | ||
|
|
||
| @RunWith(JUnit4.class) | ||
| public class QueryOptionsTest extends AbstractMockServerTest { | ||
|
|
||
| @Test | ||
| public void testUseOptimizerVersionFromConnectionUrl() { | ||
| try (Connection connection = createConnection("?optimizerVersion=10")) { | ||
| Repeat.twice( | ||
| () -> { | ||
| executeSelect1AndConsumeResults(connection); | ||
|
|
||
| assertEquals(1, mockSpanner.countRequestsOfType(ExecuteSqlRequest.class)); | ||
| ExecuteSqlRequest request = | ||
| mockSpanner.getRequestsOfType(ExecuteSqlRequest.class).get(0); | ||
| assertEquals("10", request.getQueryOptions().getOptimizerVersion()); | ||
|
|
||
| mockSpanner.clearRequests(); | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testUseOptimizerVersionFromStatement() { | ||
| try (Connection connection = createConnection()) { | ||
| connection.execute(Statement.of("set optimizer_version='7'")); | ||
|
|
||
| Repeat.twice( | ||
| () -> { | ||
| executeSelect1AndConsumeResults(connection); | ||
|
|
||
| assertEquals(1, mockSpanner.countRequestsOfType(ExecuteSqlRequest.class)); | ||
| ExecuteSqlRequest request = | ||
| mockSpanner.getRequestsOfType(ExecuteSqlRequest.class).get(0); | ||
| assertEquals("7", request.getQueryOptions().getOptimizerVersion()); | ||
|
|
||
| mockSpanner.clearRequests(); | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| private void executeSelect1AndConsumeResults(Connection connection) { | ||
| try (ResultSet resultSet = connection.executeQuery(SELECT1_STATEMENT)) { | ||
| //noinspection StatementWithEmptyBody | ||
| while (resultSet.next()) { | ||
| // ignore | ||
| } | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to also pass optimizerVersion here and verify that its overridden?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good point. But this test is not intended to specifically verify that, and we also have specific tests that cover that here:
java-spanner/google-cloud-spanner/src/test/java/com/google/cloud/spanner/connection/ConnectionTest.java
Line 60 in aa9ad7f