New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: remove custom transport executor #2366

Merged

olavloite merged 3 commits into main from remove-custom-executor

Apr 12, 2023

Collaborator

olavloite commented Apr 7, 2023

Remove the custom executor provider that is set on the underlying generated clients and instead use the internal core gRPC executor provider. The latter is a shared executor provider for all gRPC channels that creates threads on demand. This prevents the creation of unnecessary threads at startup, and can reduce overall thread usage for applications that create multiple Spanner instances during their lifetime.


          perf: remove custom transport executor

c87d41a

Remove the custom executor provider that is set on the underlying generated
clients and instead use the internal core gRPC executor provider. The latter
is a shared executor provider for all gRPC channels that creates threads on
demand. This prevents the creation of unnecessary threads at startup, and can
reduce overall thread usage for applications that create multiple Spanner
instances during their lifetime.

olavloite requested a review from a team as a code owner

April 7, 2023 10:13

product-auto-label bot added size: l api: spanner labels


          🦉 Updates from OwlBot post-processor

6d4c643

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

gcf-owl-bot bot requested a review from a team as a code owner

April 7, 2023 10:16


          Merge branch 'main' into remove-custom-executor

4cc601f

olavloite requested a review from thiagotnunes

April 9, 2023 09:40

olavloite commented

View reviewed changes

google-cloud-spanner/src/test/java/com/google/cloud/spanner/BaseSessionPoolTest.java

@@ @@ -54,7 +54,10 @@ public ScheduledExecutorService get() { @@
                   @Override
                   public void release(ScheduledExecutorService executor) {
-                    executor.shutdown();
+                    try {

Collaborator Author

olavloite Apr 12, 2023

This cleans up errors that are being logged during tests, clogging up the test log.

olavloite commented

View reviewed changes

google-cloud-spanner/src/test/java/com/google/cloud/spanner/SpannerOptionsTest.java

-                      SpannerOptions.newBuilder().setProjectId("test-project").enableGrpcGcpExtension().build();
+                      SpannerOptions.newBuilder()
+                          .setProjectId("test-project")
+                          .setCredentials(NoCredentials.getInstance())

Collaborator Author

olavloite Apr 12, 2023

This cleans up errors that are being logged during tests, clogging up the test log.

olavloite commented

View reviewed changes

google-cloud-spanner/src/test/java/com/google/cloud/spanner/SpannerOptionsTest.java

+                  SpannerOptions options =
+                      SpannerOptions.newBuilder()
+                          .setProjectId("test-project")
+                          .setCredentials(NoCredentials.getInstance())

Collaborator Author

olavloite Apr 12, 2023

This cleans up errors that are being logged during tests, clogging up the test log.

olavloite commented

View reviewed changes

google-cloud-spanner/src/test/java/com/google/cloud/spanner/SpannerOptionsTest.java

@@ @@ -943,6 +951,7 @@ public void testNumChannelsWithGrpcGcpExtensionEnabled() { @@
                   SpannerOptions options1 =
                       SpannerOptions.newBuilder()
                           .setProjectId("test-project")
+                          .setCredentials(NoCredentials.getInstance())

Collaborator Author

olavloite Apr 12, 2023

This cleans up errors that are being logged during tests, clogging up the test log.

olavloite commented

View reviewed changes

google-cloud-spanner/src/test/java/com/google/cloud/spanner/SpannerOptionsTest.java

@@ @@ -954,6 +963,7 @@ public void testNumChannelsWithGrpcGcpExtensionEnabled() { @@
                   SpannerOptions options2 =
                       SpannerOptions.newBuilder()
                           .setProjectId("test-project")
+                          .setCredentials(NoCredentials.getInstance())

Collaborator Author

olavloite Apr 12, 2023

This cleans up errors that are being logged during tests, clogging up the test log.

olavloite commented

View reviewed changes

google-cloud-spanner/src/test/java/com/google/cloud/spanner/SpannerOptionsTest.java

                   Spanner spanner2 = options1.getService();
                   assertNotSame(spanner1, spanner2);
+                  spanner1.close();

Collaborator Author

olavloite Apr 12, 2023

This cleans up errors that are being logged during tests, clogging up the test log.

olavloite commented

View reviewed changes

google-cloud-spanner/src/test/java/com/google/cloud/spanner/SpannerOptionsTest.java

-                      SpannerOptions.newBuilder().setProjectId("test-project").enableGrpcGcpExtension().build();
+                      SpannerOptions.newBuilder()
+                          .setProjectId("test-project")
+                          .setCredentials(NoCredentials.getInstance())

Collaborator Author

olavloite Apr 12, 2023

This cleans up errors that are being logged during tests, clogging up the test log.

olavloite commented

View reviewed changes

google-cloud-spanner/src/test/java/com/google/cloud/spanner/SpannerOptionsTest.java

                   Spanner spanner2 = options1.getService();
                   assertNotSame(spanner1, spanner2);
+                  spanner1.close();

Collaborator Author

olavloite Apr 12, 2023

This cleans up errors that are being logged during tests, clogging up the test log.

thiagotnunes approved these changes

View reviewed changes

Contributor

thiagotnunes left a comment

LGTM

olavloite merged commit e27dbe5 into main

olavloite deleted the remove-custom-executor branch

April 12, 2023 07:06

release-please bot mentioned this pull request

chore(main): release 6.40.0 #2378

Merged

gcf-merge-on-green bot pushed a commit that referenced this pull request


          chore(main): release 6.40.0 (#2378)

b48bb86

🤖 I have created a release *beep* *boop*
---


## [6.40.0](https://togithub.com/googleapis/java-spanner/compare/v6.39.0...v6.40.0) (2023-04-14)


### Features

* Savepoints ([#2278](https://togithub.com/googleapis/java-spanner/issues/2278)) ([b02f584](https://togithub.com/googleapis/java-spanner/commit/b02f58435b97346cc8e08a96635affe8383981bb))


### Performance Improvements

* Remove custom transport executor ([#2366](https://togithub.com/googleapis/java-spanner/issues/2366)) ([e27dbe5](https://togithub.com/googleapis/java-spanner/commit/e27dbe5f58229dab208eeeed44d53e741700c814))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.7.0 ([#2377](https://togithub.com/googleapis/java-spanner/issues/2377)) ([40402af](https://togithub.com/googleapis/java-spanner/commit/40402af54f94f16619d018e252181db29ae6855e))
* Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.21 ([#2379](https://togithub.com/googleapis/java-spanner/issues/2379)) ([ae7262d](https://togithub.com/googleapis/java-spanner/commit/ae7262d37391c0ec2fee1dcbb24899e4fa16ae17))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.21 ([#2380](https://togithub.com/googleapis/java-spanner/issues/2380)) ([0cb159e](https://togithub.com/googleapis/java-spanner/commit/0cb159efc97f02b42f064244e3812a0fd3d82db6))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner size: l