Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support float32 type #2894

Merged
merged 28 commits into from
Feb 28, 2024
Merged

feat: support float32 type #2894

merged 28 commits into from
Feb 28, 2024

Conversation

arawind
Copy link
Contributor

@arawind arawind commented Feb 16, 2024 •
edited
Loading

TODO:

  • Remove the isCloudDevel check once FLOAT32 is supported in production (will be done after merging)
  • Un-ignore the float32 parameter tests that are waiting for a backend fix.

@arawind arawind requested review from a team as code owners February 16, 2024 16:13
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: spanner Issues related to the googleapis/java-spanner API. labels Feb 16, 2024
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 20, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 20, 2024
@arawind arawind added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 23, 2024
@arawind arawind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 23, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 23, 2024
@arpan14 arpan14 requested a review from olavloite February 23, 2024 12:32
olavloite
olavloite reviewed Feb 23, 2024
View reviewed changes
google-cloud-spanner/src/main/java/com/google/cloud/spanner/Mutation.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/StructReader.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/StructReader.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/Type.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/Value.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITFloat32Test.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITFloat32Test.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITFloat32Test.java Outdated Show resolved Hide resolved
...loud-spanner/src/test/resources/com/google/cloud/spanner/connection/it/CreateMusicTables.sql Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractStructReader.java Outdated Show resolved Hide resolved
olavloite and others added 3 commits February 23, 2024 16:49
@olavloite
test: added some additional tests
187182b
@arawind
Merge branch 'main' into float32-v2
7543083
@arawind
Update to resolve comments on PR#2894.
1057826 
Major change: Ensures that the new methods in interfaces do not break for older clients.

Minor changes: remove double cast; remove dependency on Truth assertions; remove unnecessary logic in Mutations::isNaN
@arawind arawind added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 25, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 26, 2024
olavloite
olavloite approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming that the test failure is unrelated)

@arawind arawind added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2024
@arawind
Copy link
Contributor Author

arawind commented Feb 28, 2024

The cloud-devel failures are unrelated and all FLOAT32 integration tests have passed on cloud-devel.

From https://source.cloud.google.com/results/invocations/3dd1b019-0668-4964-a2bc-512009d741ef:

[INFO] Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.336 s -- in com.google.cloud.spanner.it.ITFloat32Test

@arawind arawind merged commit 19b7976 into googleapis:main Feb 28, 2024
25 of 26 checks passed
@arawind arawind deleted the float32-v2 branch February 28, 2024 10:23
@release-please release-please bot mentioned this pull request Feb 28, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 4, 2024
@release-please
chore(main): release 6.61.0 (#2926)
95bad55 
🤖 I have created a release *beep* *boop*
---


## [6.61.0](https://togithub.com/googleapis/java-spanner/compare/v6.60.1...v6.61.0) (2024-03-04)


### Features

* Support float32 type ([#2894](https://togithub.com/googleapis/java-spanner/issues/2894)) ([19b7976](https://togithub.com/googleapis/java-spanner/commit/19b79764294e938ad85d02b7c0662db6ec3afeda))


### Bug Fixes

* Flaky test issue due to AbortedException. ([#2925](https://togithub.com/googleapis/java-spanner/issues/2925)) ([cd34c1d](https://togithub.com/googleapis/java-spanner/commit/cd34c1d3ae9a5a36f4d5516dcf7c3667a9cf015a))


### Dependencies

* Update dependency com.google.cloud:sdk-platform-java-config to v3.27.0 ([#2935](https://togithub.com/googleapis/java-spanner/issues/2935)) ([f8f835a](https://togithub.com/googleapis/java-spanner/commit/f8f835a9da705605c492e232a58276c39d1d7e6c))
* Update dependency org.json:json to v20240303 ([#2936](https://togithub.com/googleapis/java-spanner/issues/2936)) ([1d7044e](https://togithub.com/googleapis/java-spanner/commit/1d7044e97d16f5296b7de020cd24b11cbe2a7df0))


### Documentation

* Samples and tests for backup Admin APIs and overall spanner Admin APIs. ([#2882](https://togithub.com/googleapis/java-spanner/issues/2882)) ([de13636](https://togithub.com/googleapis/java-spanner/commit/de1363645e03f46deed5be41f90ddfed72766751))
* Update all public documents to use auto-generated admin clients. ([#2928](https://togithub.com/googleapis/java-spanner/issues/2928)) ([ccb110a](https://togithub.com/googleapis/java-spanner/commit/ccb110ad6835557870933c95cfd76580fd317a16))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This was referenced Mar 8, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arpan14 arpan14 arpan14 approved these changes

@olavloite olavloite olavloite approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arawind @olavloite @arpan14 @rahul2393 @yoshi-kokoro