fix: upgrade libraries-bom to 26.34.0 and add spanner support float32 type #2662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [com.google.cloud:libraries-bom](https://github.com/googleapis/java-cloud-bom) from 26.33.0 to 26.34.0. - [Release notes](https://github.com/googleapis/java-cloud-bom/releases) - [Changelog](https://github.com/googleapis/java-cloud-bom/blob/main/release-please-config.json) - [Commits](googleapis/java-cloud-bom@v26.33.0...v26.34.0) --- updated-dependencies: - dependency-name: com.google.cloud:libraries-bom dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
it test failure: |
zhumin8
changed the title
|
Could you add a unit test to verify the behavior, or why it can't be tested? |
Ah, good point. Adding them in now. This change is covered by existing tests: SpannerWriteMethodCoverageTests and SpannerStructReadMethodCoverageTests, but additional unit tests are added in b012c9d |
|
|
@JoeWang1127 Can you please take another look? |
JoeWang1127
approved these changes
Mar 11, 2024
1 task
zhumin8
added a commit
that referenced
this pull request
Mar 11, 2024
… type (#2662) * deps: bump com.google.cloud:libraries-bom from 26.33.0 to 26.34.0 Bumps [com.google.cloud:libraries-bom](https://github.com/googleapis/java-cloud-bom) from 26.33.0 to 26.34.0. - [Release notes](https://github.com/googleapis/java-cloud-bom/releases) - [Changelog](https://github.com/googleapis/java-cloud-bom/blob/main/release-please-config.json) - [Commits](googleapis/java-cloud-bom@v26.33.0...v26.34.0) --- updated-dependencies: - dependency-name: com.google.cloud:libraries-bom dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * feat(spanner): support float32 type. * chore: add unit tests for float32. * fix: add float32 to type mapper and corresponding unit tests. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
zhumin8
added a commit
that referenced
this pull request
Mar 11, 2024
… type (#2662) * deps: bump com.google.cloud:libraries-bom from 26.33.0 to 26.34.0 Bumps [com.google.cloud:libraries-bom](https://github.com/googleapis/java-cloud-bom) from 26.33.0 to 26.34.0. - [Release notes](https://github.com/googleapis/java-cloud-bom/releases) - [Changelog](https://github.com/googleapis/java-cloud-bom/blob/main/release-please-config.json) - [Commits](googleapis/java-cloud-bom@v26.33.0...v26.34.0) --- updated-dependencies: - dependency-name: com.google.cloud:libraries-bom dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * feat(spanner): support float32 type. * chore: add unit tests for float32. * fix: add float32 to type mapper and corresponding unit tests. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Mar 11, 2024
zhumin8
added a commit
that referenced
this pull request
Mar 12, 2024
… type (#2662) (#2667) * deps: bump com.google.cloud:libraries-bom from 26.33.0 to 26.34.0 Bumps [com.google.cloud:libraries-bom](https://github.com/googleapis/java-cloud-bom) from 26.33.0 to 26.34.0. - [Release notes](https://github.com/googleapis/java-cloud-bom/releases) - [Changelog](https://github.com/googleapis/java-cloud-bom/blob/main/release-please-config.json) - [Commits](googleapis/java-cloud-bom@v26.33.0...v26.34.0) --- updated-dependencies: - dependency-name: com.google.cloud:libraries-bom dependency-type: direct:production update-type: version-update:semver-minor ... * feat(spanner): support float32 type. * chore: add unit tests for float32. * fix: add float32 to type mapper and corresponding unit tests. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
zhumin8
added a commit
that referenced
this pull request
Mar 13, 2024
… type (#2662) (#2668) * deps: bump com.google.cloud:libraries-bom from 26.33.0 to 26.34.0 Bumps [com.google.cloud:libraries-bom](https://github.com/googleapis/java-cloud-bom) from 26.33.0 to 26.34.0. - [Release notes](https://github.com/googleapis/java-cloud-bom/releases) - [Changelog](https://github.com/googleapis/java-cloud-bom/blob/main/release-please-config.json) - [Commits](googleapis/java-cloud-bom@v26.33.0...v26.34.0) --- updated-dependencies: - dependency-name: com.google.cloud:libraries-bom dependency-type: direct:production update-type: version-update:semver-minor ... * feat(spanner): support float32 type. * chore: add unit tests for float32. * fix: add float32 to type mapper and corresponding unit tests. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spanner client library added new feat googleapis/java-spanner#2894 in v6.61.0, changes in spanner module accordingly to support it.
This change is covered by existing tests:
SpannerWriteMethodCoverageTestsandSpannerStructReadMethodCoverageTests.These tests checks that the converter is aware of all Spanner mutation binder types (to write) & struct getter types (to read).
This should fix test failures in #2659 (comment), and closes #2659.
Need to back-port to 4.x and 3.x branches
BEGIN_COMMIT_OVERRIDE
deps: bump com.google.cloud:libraries-bom from 26.33.0 to 26.34.0
feat(spanner): support float32 type.
END_COMMIT_OVERRIDE