Skip to content

Commit

Permalink
fix: declaring test-scope artifact as runtime (#1186)
Browse files Browse the repository at this point in the history
* fix: declaring test-scope artifact as runtime

* docs: adding comments
  • Loading branch information
suztomo committed Aug 8, 2022
1 parent 94b6268 commit d3b0244
Showing 1 changed file with 11 additions and 5 deletions.
16 changes: 11 additions & 5 deletions google-cloud-pubsublite/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,17 @@
<groupId>com.google.api</groupId>
<artifactId>gax-grpc</artifactId>
</dependency>
<dependency>
<groupId>com.google.code.gson</groupId>
<artifactId>gson</artifactId>
<!--
Within this repository this dependency is only used in tests. However,
making this test scope causes undeclared dependencies after the
flatten-maven-plugin.
https://github.com/mojohaus/flatten-maven-plugin/issues/185
-->
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-protobuf</artifactId>
Expand Down Expand Up @@ -129,11 +140,6 @@
<version>2.2</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.code.gson</groupId>
<artifactId>gson</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava-testlib</artifactId>
Expand Down

0 comments on commit d3b0244

Please sign in to comment.