Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: temporarily remove publisher tests causing timeouts #1860

Merged
merged 22 commits into from
Jan 12, 2024
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
01401ac
Update PublisherImplTest.java
hannahrogers-google Jan 12, 2024
e7c0c39
Update PublisherImplTest.java
hannahrogers-google Jan 12, 2024
f58238c
Update PublisherImplTest.java
hannahrogers-google Jan 12, 2024
88a22eb
Update PublisherImplTest.java
hannahrogers-google Jan 12, 2024
cc32d5b
Update PublisherImplTest.java
hannahrogers-google Jan 12, 2024
58a8441
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 12, 2024
3fe0afd
Update PublisherImplTest.java
hannahrogers-google Jan 12, 2024
3ac2b93
Update PublisherImplTest.java
hannahrogers-google Jan 12, 2024
b973b2a
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 12, 2024
4219182
Update PublisherImplTest.java
hannahrogers-google Jan 12, 2024
0c71e42
Update PublisherImplTest.java
hannahrogers-google Jan 12, 2024
067706e
Update PublisherImplTest.java
hannahrogers-google Jan 12, 2024
1ce4b91
Update PublisherImplTest.java
hannahrogers-google Jan 12, 2024
93dcab0
Update PublisherImplTest.java
hannahrogers-google Jan 12, 2024
7b92be7
Update PublisherImplTest.java
hannahrogers-google Jan 12, 2024
45211cb
Update PublisherImplTest.java
hannahrogers-google Jan 12, 2024
5d6b109
Update PublisherImplTest.java
hannahrogers-google Jan 12, 2024
7acbabf
Update PublisherImplTest.java
hannahrogers-google Jan 12, 2024
d4230d2
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 12, 2024
4f46d68
Update PublisherImplTest.java
hannahrogers-google Jan 12, 2024
543099b
fix: temporarily remove publisher tests causing timeouts
hannahrogers-google Jan 12, 2024
c6a619c
Update PublisherImplTest.java
hannahrogers-google Jan 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@
import java.util.concurrent.TimeUnit;
import org.easymock.EasyMock;
import org.junit.After;
import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
Expand Down Expand Up @@ -501,7 +500,6 @@ public void testEnableMessageOrdering_overwritesMaxAttempts() throws Exception {
assertTrue(publisher.awaitTermination(1, TimeUnit.MINUTES));
}

@Test
/**
* Make sure that resume publishing works as expected:
*
Expand All @@ -513,6 +511,10 @@ public void testEnableMessageOrdering_overwritesMaxAttempts() throws Exception {
* <li>publish with key orderA, which should now succeed
* </ol>
*/
/*
Temporarily disabled due to https://github.com/googleapis/java-pubsub/issues/1861.
TODO(maitrimangal): Enable once resolved.
@Test
public void testResumePublish() throws Exception {
Publisher publisher =
getTestPublisherBuilder()
Expand All @@ -538,13 +540,13 @@ public void testResumePublish() throws Exception {

try {
future1.get();
Assert.fail("This should fail.");
fail("This should fail.");
} catch (ExecutionException e) {
}

try {
future2.get();
Assert.fail("This should fail.");
fail("This should fail.");
} catch (ExecutionException e) {
}

Expand All @@ -554,14 +556,14 @@ public void testResumePublish() throws Exception {

try {
future3.get();
Assert.fail("This should fail.");
fail("This should fail.");
} catch (ExecutionException e) {
assertEquals(SequentialExecutorService.CallbackExecutor.CANCELLATION_EXCEPTION, e.getCause());
}

try {
future4.get();
Assert.fail("This should fail.");
fail("This should fail.");
} catch (ExecutionException e) {
assertEquals(SequentialExecutorService.CallbackExecutor.CANCELLATION_EXCEPTION, e.getCause());
}
Expand Down Expand Up @@ -641,6 +643,7 @@ public void testPublishThrowExceptionForUnsubmittedOrderingKeyMessage() throws E
assertEquals(SequentialExecutorService.CallbackExecutor.CANCELLATION_EXCEPTION, e.getCause());
}
}
*/

private ApiFuture<String> sendTestMessageWithOrderingKey(
Publisher publisher, String data, String orderingKey) {
Expand Down
Loading