-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Cloud Run Jobs support #1574
Conversation
5f83bd6
to
24b837e
Compare
Put this PR on hold due to code freeze. Will resume merging and releasing once feeze is over. |
enhancers.add( | ||
new LabelLoggingEnhancer( | ||
CLOUD_RUN_JOB_LABEL_PREFIX, | ||
ImmutableList.of(Label.CloudRunJobExecutionName, Label.CloudRunJobTaskIndex))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to this (https://cloud.google.com/logging/docs/api/platform-logs#cloud_run) you're missing a label for task attempt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Added cloud run task attempt label into enhancer.
…ogging into cindy/cloudrun
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merging this PR for now since customers are blocked on this. |
🤖 I have created a release *beep* *boop* --- ## [3.17.0](https://togithub.com/googleapis/java-logging/compare/v3.16.3...v3.17.0) (2024-04-25) ### Features * Add Cloud Run Jobs support ([#1574](https://togithub.com/googleapis/java-logging/issues/1574)) ([1dd64d0](https://togithub.com/googleapis/java-logging/commit/1dd64d078e0d4cbb1e16cb1d050ba192492d6a60)) ### Bug Fixes * **deps:** Update the Java code generator (gapic-generator-java) to 2.39.0 ([#1587](https://togithub.com/googleapis/java-logging/issues/1587)) ([848418b](https://togithub.com/googleapis/java-logging/commit/848418b426c2e93e636dbd9de71985c386ccb9d2)) ### Dependencies * Update dependency com.google.cloud:sdk-platform-java-config to v3.29.0 ([#1586](https://togithub.com/googleapis/java-logging/issues/1586)) ([edcaf8d](https://togithub.com/googleapis/java-logging/commit/edcaf8de643a7f7f419ee6059c706d0ef0ef4873)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1514 ☕️
If you write sample code, please follow the samples format.