Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: java record serialization/deserialization #1842

Merged
merged 80 commits into from
Sep 25, 2024
Merged

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Sep 20, 2024

The previously merged feature branch caused javadoc failure on release stage,
and it is reverted: #1833

Readjusting the profile for the "google-cloud-firestore/src/test-jdk17" to be activated only when runTestsWithJava17 flag is on instead of checking jdk version.

eranl and others added 30 commits March 4, 2023 02:34
…cloud-firestore module by adding a test-jdk17 directory and a java17 profile, and eliminate google-cloud-firestore-jdk17 module
This reverts commit 646ff81.
Copy link

generated-files-bot bot commented Sep 24, 2024

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml
  • .kokoro/build.sh

@milaGGL milaGGL marked this pull request as ready for review September 24, 2024 19:22
@milaGGL milaGGL requested review from a team as code owners September 24, 2024 19:22
Copy link

@ldetmer ldetmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for workflow changes

@milaGGL milaGGL merged commit aff93bf into main Sep 25, 2024
23 of 24 checks passed
@milaGGL milaGGL deleted the mila/test-record branch September 25, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/java-firestore API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants