Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding default retry settings for consistency check #2469

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Adding default retry settings for consistency check #2469

wants to merge 2 commits into from

Conversation

sandshar09
Copy link

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@sandshar09 sandshar09 requested review from a team as code owners January 16, 2025 05:52
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 16, 2025
@generated-files-bot Generated Files Bot
Copy link

Warning: This pull request is touching the following templated files:

  • google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableTableAdminStubSettings.java

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Jan 16, 2025
justinuang
justinuang reviewed Jan 16, 2025
View reviewed changes
...le/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableTableAdminStubSettings.java Outdated
.setMaxRetryDelayDuration(Duration.ofMillis(60000L))
.setInitialRpcTimeoutDuration(Duration.ofMillis(3600000L))
.setRpcTimeoutMultiplier(1.0)
.setMaxRpcTimeoutDuration(Duration.ofMillis(3600000L))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be set back to 60000L, since it's not a single RPC we're concerned about.

Need to also double check with @igorbernstein2 if we're okay with the replication check consistency potentially taking up to 1h as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed single rpc timeout to 1 minute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinuang justinuang justinuang left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandshar09 @justinuang