Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bigtable): Remove deprecated Bytes from BigEndianBytesEncoding #2309

Merged
merged 7 commits into from
Aug 13, 2024
Merged

feat(bigtable): Remove deprecated Bytes from BigEndianBytesEncoding #2309

merged 7 commits into from
Aug 13, 2024

Conversation

ron-gal
Copy link
Contributor

@ron-gal ron-gal commented Aug 9, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Aug 9, 2024
@ron-gal ron-gal marked this pull request as ready for review August 9, 2024 03:54
@ron-gal ron-gal requested review from a team as code owners August 9, 2024 03:54
@steveniemitz
Copy link
Contributor

/gcbrun

@steveniemitz
Copy link
Contributor

similar to my comment on the go side, I'm fine with an API breaking change here:

  • This is still @BetaAPI (we should remove that though)
  • It has only existed for ~a week
  • Its unlikely anyone is using the more complicated builder API that we changed here anyways

@steveniemitz steveniemitz added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 9, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 9, 2024
@steveniemitz
Copy link
Contributor

/gcbrun

@steveniemitz steveniemitz added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 13, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 13, 2024
@steveniemitz steveniemitz merged commit 32f244f into googleapis:main Aug 13, 2024
21 checks passed
@release-please release-please bot mentioned this pull request Aug 22, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 23, 2024
@release-please
chore(main): release 2.43.0 (#2323)
8359a87 
🤖 I have created a release *beep* *boop*
---


## [2.43.0](https://togithub.com/googleapis/java-bigtable/compare/v2.42.0...v2.43.0) (2024-08-22)


### Features

* Add fields and the BackupType proto for Hot Backups ([#2300](https://togithub.com/googleapis/java-bigtable/issues/2300)) ([acaa3ff](https://togithub.com/googleapis/java-bigtable/commit/acaa3ff26ab0d317362e2be65ac5edcf803b13a1))
* Allow non default service account in DirectPath ([#2312](https://togithub.com/googleapis/java-bigtable/issues/2312)) ([09d0f23](https://togithub.com/googleapis/java-bigtable/commit/09d0f23032488dfa55c7a4c1c571a4f36bd94728))
* **bigtable:** Remove deprecated Bytes from BigEndianBytesEncoding ([#2309](https://togithub.com/googleapis/java-bigtable/issues/2309)) ([32f244f](https://togithub.com/googleapis/java-bigtable/commit/32f244f13d0c8571654d314310a4756fe275d609))
* Enable hermetic library generation ([#2234](https://togithub.com/googleapis/java-bigtable/issues/2234)) ([169aea5](https://togithub.com/googleapis/java-bigtable/commit/169aea5c43485a8d13ed53f57495609c142944df))


### Bug Fixes

* Add missing call to EqualsTester#testEquals ([#2307](https://togithub.com/googleapis/java-bigtable/issues/2307)) ([8b49f9c](https://togithub.com/googleapis/java-bigtable/commit/8b49f9ce84871f0f423f5837785604c3119ccd88))


### Dependencies

* Update shared dependencies ([#2314](https://togithub.com/googleapis/java-bigtable/issues/2314)) ([ab392ee](https://togithub.com/googleapis/java-bigtable/commit/ab392ee8d0c4535b5d3f31b3e111cbc41b399dd9))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveniemitz steveniemitz steveniemitz approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ron-gal @steveniemitz