feat: publish the RequestStats proto (#1400)

* docs: Remove unnecessary comment PiperOrigin-RevId: 474807836 Source-Link: googleapis/googleapis@dfd68f7 Source-Link: https://github.com/googleapis/googleapis-gen/commit/fe305e0252bc9a88466e1b96c2f2464dd729b978 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZmUzMDVlMDI1MmJjOWE4ODQ2NmUxYjk2YzJmMjQ2NGRkNzI5Yjk3OCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: publish the RequestStats proto PiperOrigin-RevId: 476399682 Source-Link: googleapis/googleapis@0c4e682 Source-Link: https://github.com/googleapis/googleapis-gen/commit/ff87f69aad1f2ff06772f917eecbea649797d9d5 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZmY4N2Y2OWFhZDFmMmZmMDY3NzJmOTE3ZWVjYmVhNjQ5Nzk3ZDlkNSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * add to clirr ignored differences Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Kristen O'Leary <kaoleary@google.com>
googleapis · Sep 28, 2022 · e989200 · e989200
1 parent 58406a9
commit e989200
Show file tree

Hide file tree

Showing 33 changed files with 7,361 additions and 635 deletions.
diff --git a/...gtable/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminClient.java b/...gtable/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminClient.java
@@ -922,8 +922,7 @@ public final UnaryCallable<GetTableRequest, Table> getTableCallable() {
    * }</pre>
    *
    * @param table Required. The table to update. The table's `name` field is used to identify the
-   *     table to update. Format:
-   *     `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]&#42;`
+   *     table to update.
    * @param updateMask Required. The list of fields to update. A mask specifying which fields (e.g.
    *     `deletion_protection`) in the `table` field should be updated. This mask is relative to the
    *     `table` field, not to the request message. The wildcard (&#42;) path is currently not

diff --git a/...loud-bigtable-admin-v2/src/main/java/com/google/bigtable/admin/v2/UpdateTableRequest.java b/...loud-bigtable-admin-v2/src/main/java/com/google/bigtable/admin/v2/UpdateTableRequest.java
@@ -143,8 +143,6 @@ public static final com.google.protobuf.Descriptors.Descriptor getDescriptor() {
    * <pre>
    * Required. The table to update.
    * The table's `name` field is used to identify the table to update.
-   * Format:
-   * `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
    * </pre>
    *
    * <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
@@ -162,8 +160,6 @@ public boolean hasTable() {
    * <pre>
    * Required. The table to update.
    * The table's `name` field is used to identify the table to update.
-   * Format:
-   * `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
    * </pre>
    *
    * <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
@@ -181,8 +177,6 @@ public com.google.bigtable.admin.v2.Table getTable() {
    * <pre>
    * Required. The table to update.
    * The table's `name` field is used to identify the table to update.
-   * Format:
-   * `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
    * </pre>
    *
    * <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
@@ -633,8 +627,6 @@ public Builder mergeFrom(
      * <pre>
      * Required. The table to update.
      * The table's `name` field is used to identify the table to update.
-     * Format:
-     * `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
      * </pre>
      *
      * <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
@@ -651,8 +643,6 @@ public boolean hasTable() {
      * <pre>
      * Required. The table to update.
      * The table's `name` field is used to identify the table to update.
-     * Format:
-     * `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
      * </pre>
      *
      * <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
@@ -673,8 +663,6 @@ public com.google.bigtable.admin.v2.Table getTable() {
      * <pre>
      * Required. The table to update.
      * The table's `name` field is used to identify the table to update.
-     * Format:
-     * `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
      * </pre>
      *
      * <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
@@ -699,8 +687,6 @@ public Builder setTable(com.google.bigtable.admin.v2.Table value) {
      * <pre>
      * Required. The table to update.
      * The table's `name` field is used to identify the table to update.
-     * Format:
-     * `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
      * </pre>
      *
      * <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
@@ -722,8 +708,6 @@ public Builder setTable(com.google.bigtable.admin.v2.Table.Builder builderForVal
      * <pre>
      * Required. The table to update.
      * The table's `name` field is used to identify the table to update.
-     * Format:
-     * `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
      * </pre>
      *
      * <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
@@ -750,8 +734,6 @@ public Builder mergeTable(com.google.bigtable.admin.v2.Table value) {
      * <pre>
      * Required. The table to update.
      * The table's `name` field is used to identify the table to update.
-     * Format:
-     * `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
      * </pre>
      *
      * <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
@@ -774,8 +756,6 @@ public Builder clearTable() {
      * <pre>
      * Required. The table to update.
      * The table's `name` field is used to identify the table to update.
-     * Format:
-     * `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
      * </pre>
      *
      * <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
@@ -792,8 +772,6 @@ public com.google.bigtable.admin.v2.Table.Builder getTableBuilder() {
      * <pre>
      * Required. The table to update.
      * The table's `name` field is used to identify the table to update.
-     * Format:
-     * `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
      * </pre>
      *
      * <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
@@ -812,8 +790,6 @@ public com.google.bigtable.admin.v2.TableOrBuilder getTableOrBuilder() {
      * <pre>
      * Required. The table to update.
      * The table's `name` field is used to identify the table to update.
-     * Format:
-     * `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
      * </pre>
      *
      * <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];

diff --git a/...able-admin-v2/src/main/java/com/google/bigtable/admin/v2/UpdateTableRequestOrBuilder.java b/...able-admin-v2/src/main/java/com/google/bigtable/admin/v2/UpdateTableRequestOrBuilder.java
@@ -29,8 +29,6 @@ public interface UpdateTableRequestOrBuilder
    * <pre>
    * Required. The table to update.
    * The table's `name` field is used to identify the table to update.
-   * Format:
-   * `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
    * </pre>
    *
    * <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
@@ -45,8 +43,6 @@ public interface UpdateTableRequestOrBuilder
    * <pre>
    * Required. The table to update.
    * The table's `name` field is used to identify the table to update.
-   * Format:
-   * `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
    * </pre>
    *
    * <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
@@ -61,8 +57,6 @@ public interface UpdateTableRequestOrBuilder
    * <pre>
    * Required. The table to update.
    * The table's `name` field is used to identify the table to update.
-   * Format:
-   * `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
    * </pre>
    *
    * <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];

diff --git a/...loud-bigtable-admin-v2/src/main/proto/google/bigtable/admin/v2/bigtable_table_admin.proto b/...loud-bigtable-admin-v2/src/main/proto/google/bigtable/admin/v2/bigtable_table_admin.proto
@@ -381,8 +381,8 @@ message RestoreTableRequest {
     // Name of the backup from which to restore.  Values are of the form
     // `projects/<project>/instances/<instance>/clusters/<cluster>/backups/<backup>`.
     string backup = 3 [(google.api.resource_reference) = {
-      type: "bigtableadmin.googleapis.com/Backup"
-    }];
+                         type: "bigtableadmin.googleapis.com/Backup"
+                       }];
   }
 }
 
@@ -597,8 +597,6 @@ message GetTableRequest {
 message UpdateTableRequest {
   // Required. The table to update.
   // The table's `name` field is used to identify the table to update.
-  // Format:
-  // `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
   Table table = 1 [(google.api.field_behavior) = REQUIRED];
 
   // Required. The list of fields to update.

diff --git a/proto-google-cloud-bigtable-v2/clirr-ignored-differences.xml b/proto-google-cloud-bigtable-v2/clirr-ignored-differences.xml
@@ -4,6 +4,16 @@
   <difference>
     <differenceType>7012</differenceType>
     <className>com/google/bigtable/v2/*OrBuilder</className>
-    <method>* has*(*)</method>
+    <method>* get*(*)</method>
+  </difference>
+  <difference>
+    <differenceType>7012</differenceType>
+    <className>com/google/bigtable/v2/*OrBuilder</className>
+    <method>boolean contains*(*)</method>
+  </difference>
+  <difference>
+    <differenceType>7012</differenceType>
+    <className>com/google/bigtable/v2/*OrBuilder</className>
+    <method>boolean has*(*)</method>
   </difference>
 </differences>