add toString

googleapis · Feb 21, 2024 · 8f511cf · 8f511cf
1 parent db6c496
commit 8f511cf
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 1 deletion.
diff --git a/...-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataSettings.java b/...-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataSettings.java
@@ -216,6 +216,7 @@ public static void enableBuiltinMetrics() throws IOException {}
    *     now. Please refer {@link BigtableDataSettings.Builder#setMetricsProvider(MetricsProvider)}
    *     on how to enable or disable built-in metrics.
    */
+  @Deprecated
   public static void enableBuiltinMetrics(Credentials credentials) throws IOException {
     BigtableDataSettings.legacyMetricCredentialOverride = credentials;
   }

diff --git a/...le/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTracer.java b/...le/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTracer.java
@@ -363,7 +363,7 @@ private void recordAttemptCompletion(@Nullable Throwable status) {
     }
   }
 
-  private double convertToMs(long nanoSeconds) {
+  private static double convertToMs(long nanoSeconds) {
     double toMs = 1e-6;
     return nanoSeconds * toMs;
   }

diff --git a/...va/com/google/cloud/bigtable/data/v2/stub/metrics/CustomOpenTelemetryMetricsProvider.java b/...va/com/google/cloud/bigtable/data/v2/stub/metrics/CustomOpenTelemetryMetricsProvider.java
@@ -61,4 +61,9 @@ private CustomOpenTelemetryMetricsProvider(OpenTelemetry otel) {
   public OpenTelemetry getOpenTelemetry() {
     return otel;
   }
+
+  @Override
+  public String toString() {
+    return otel.toString();
+  }
 }
diff --git a/.../src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/DefaultMetricsProvider.java b/.../src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/DefaultMetricsProvider.java
@@ -27,4 +27,9 @@ public final class DefaultMetricsProvider implements MetricsProvider {
   public static DefaultMetricsProvider INSTANCE = new DefaultMetricsProvider();
 
   private DefaultMetricsProvider() {}
+
+  @Override
+  public String toString() {
+    return "DefaultMetricsProvider";
+  }
 }
diff --git a/...ble/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/NoopMetricsProvider.java b/...ble/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/NoopMetricsProvider.java
@@ -26,4 +26,9 @@ public final class NoopMetricsProvider implements MetricsProvider {
   public static NoopMetricsProvider INSTANCE = new NoopMetricsProvider();
 
   private NoopMetricsProvider() {}
+
+  @Override
+  public String toString() {
+    return "NoopMetricsProvider";
+  }
 }