-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix IdTokenVerifier so it does not cache empty entries #892
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
acb985f
verifier signature fix port
TimurSadykov 1c16f8f
more test cases
TimurSadykov 872f5f6
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 70ac584
fix: more test fixes
TimurSadykov 5dde913
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 5c83d47
Update google-oauth-client/src/main/java/com/google/api/client/auth/o…
TimurSadykov 17affb3
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 4d34201
fix: restored original interface for verifier, added default http fac…
TimurSadykov 9611f53
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 8b55b29
Update google-oauth-client/src/main/java/com/google/api/client/auth/o…
TimurSadykov 813bb20
Update google-oauth-client/src/main/java/com/google/api/client/auth/o…
TimurSadykov e065d1a
doc fixes
TimurSadykov 1af2370
fix: better docs and logging of validation exceptions
TimurSadykov 22178ca
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] c8d01d3
Update google-oauth-client/src/main/java/com/google/api/client/auth/o…
TimurSadykov aca11aa
nit and linter fixes
TimurSadykov 1d668f8
Merge remote-tracking branch 'origin/main' into stim-signer
TimurSadykov 6cd7d8c
fix: add verify without signature verification, remove caching empty …
TimurSadykov 964c5a8
fix: docs for a new method
TimurSadykov d51d221
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 8f9f8f1
fix: docs for a new method
TimurSadykov ff2474e
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 50eb0cc
fix: more test cases
TimurSadykov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Memo for myself.
Now this throws an exception. With Guava's LoadingCache, the exception surfaces as ExecutionException in
publicKeyCache.get
inverifySignature
method. ThisverifySignature
method wraps it asVerificationException
. Theverify
method catchesVerificationException
, logs the SEVERE-level message, and returns false.With this change the LoadingCache now stops caching failure result. A potential problem would be the library users calling the verify method repeatedly in a situation where the certificate location is inaccessible. From the caller's perspective, the result (getting
false
) remains the same. In that caseIdTokenVerifier$PublicKeyLoader
logs the warning message. The user can easily tell the problem. This should be fine.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, had similar thoughts on this