Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: standardize data proto descriptions #120

Merged
merged 1 commit into from
Nov 30, 2020
Merged

fix: standardize data proto descriptions #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions proto/google/events/cloud/audit/v1/data.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,7 @@ import "google/rpc/status.proto";

option csharp_namespace = "Google.Events.Protobuf.Cloud.Audit.V1";

// Generic log entry, used as a wrapper for Cloud Audit Logs in events.
// This is copied from
// https://github.com/googleapis/googleapis/blob/master/google/logging/v2/log_entry.proto
// and adapted appropriately.
// The data within all Cloud Audit Logs log entry events.
message LogEntryData {
// The resource name of the log to which this log entry belongs.
string log_name = 12;
Expand Down
5 changes: 1 addition & 4 deletions proto/google/events/cloud/cloudbuild/v1/data.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,7 @@ import "google/protobuf/timestamp.proto";

option csharp_namespace = "Google.Events.Protobuf.Cloud.CloudBuild.V1";

// Build event data
// Common build format for Google Cloud Platform API operations.
// Copied from
// https://github.com/googleapis/googleapis/blob/master/google/devtools/cloudbuild/v1/cloudbuild.proto.
// Build event data for Google Cloud Platform API operations.
message BuildEventData {
// Possible status of a build or build step.
enum Status {
Expand Down
2 changes: 1 addition & 1 deletion proto/google/events/cloud/pubsub/v1/data.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ package google.events.cloud.pubsub.v1;

option csharp_namespace = "Google.Events.Protobuf.Cloud.PubSub.V1";

// The data received in an event when a message is published to a topic.
// The event data when a message is published to a topic.
message MessagePublishedData {
// The message that was published.
PubsubMessage message = 1;
Expand Down
2 changes: 1 addition & 1 deletion proto/google/events/firebase/auth/v1/data.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import "google/protobuf/timestamp.proto";

option csharp_namespace = "Google.Events.Protobuf.Firebase.Auth.V1";

// The data within all Firebase Auth events
// The data within all Firebase Auth events.
message AuthEventData {
// The user identifier in the Firebase app.
string uid = 1;
Expand Down