feat: improve jsonschema types for protobuf well known types #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
product-auto-label
bot
added
the
api: eventarc
google-cla
bot
added
the
cla: yes
jskeet
reviewed
Jul 12, 2021
| "additionalProperties": true, | ||
| "type": "object", | ||
| "type": "string", |
There was a problem hiding this comment.
I'm slightly surprised there's no format part here - does this mean there's no way of a JSON schema consumer telling the difference between a duration and a string?
There was a problem hiding this comment.
We currently don't have it but we can add the formatting in the future.
jskeet
approved these changes
Jul 12, 2021
gcf-merge-on-green bot
pushed a commit
to googleapis/google-cloudevents-nodejs
that referenced
this pull request
Jul 12, 2021
Generation from updated schemas: googleapis/google-cloudevents#254 Should allow proper typing for Cloud Build types for example.
grant
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 12, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.6.0](https://www.github.com/googleapis/google-cloudevents/compare/v1.5.0...v1.6.0) (2021-07-12) ### Features * improve jsonschema types for protobuf well known types ([#254](https://www.github.com/googleapis/google-cloudevents/issues/254)) ([e59a4bf](https://www.github.com/googleapis/google-cloudevents/commit/e59a4bfd8d8777a4415062533b0fc08712e0f292)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #250
Uses
PROTOC_PLUGIN_VERSION=1.0.0.google.protobuf.Valuegoogle.protobuf.DurationThis should result in better parsing for these well known types, and types that aren't always JSON objects (hence the oneOf).
See: https://developers.google.com/protocol-buffers/docs/reference/google.protobuf
Gen'd updates to language clients would follow this PR. Unfortunately the
oneOfsyntax isn't the greatest with quicktype. Although it is the most accurate for the JSON (not everything is an object), and easier to deal with downstream. Look at the protobuf docs for your own assessment.