Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Add "format" property to google.protobuf.Duration string #66

Closed
grant opened this issue Jul 12, 2021 · 2 comments
Closed

Add "format" property to google.protobuf.Duration string #66

grant opened this issue Jul 12, 2021 · 2 comments

Comments

@grant
Copy link
Collaborator

grant commented Jul 12, 2021 •
edited
Loading

google.protobuf.Duration types should has a format / pattern property with the expected formats that are valid for this string.

Ref:

Examples:

  • "3.000001s"
  • "3s"
@grant grant mentioned this issue Jul 12, 2021
Merged
@chrusty
Copy link
Owner

chrusty commented Jul 18, 2021

A PR is open for this: #67

@chrusty
Copy link
Owner

chrusty commented Jul 20, 2021

I've merged a fix for this, and made a pre-release here: https://github.com/chrusty/protoc-gen-jsonschema/releases/tag/untagged-f8dda646aa02d3927db9

@chrusty chrusty closed this as completed Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grant @chrusty