Pass issuer and signing_key when creating a signed_url #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Credentials from non-service account JSON files, like GCE, do not have issuer and signing_key available. In those cases the users must pass in the issuer and signing_key values for signed_url to work. [refs googleapis#181]
googlebot
added
the
cla: yes
quartzmo
added a commit
that referenced
this pull request
Jul 22, 2015
Pass issuer and signing_key when creating a signed_url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A service account's
issuerandsigning_keyvalues are required to generate asigned_url. Initially, all gcloud-ruby connections were service accounts, but it now supports GCE and Cloud SDK credentials as well. These new types of credentials are missing the assertion values (issuerandsigning_key). In order to generate signed_urls these values need to be passed in.[fixes #181]