Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass issuer and signing_key when creating a signed_url #196

Merged
merged 2 commits into from
Jul 22, 2015

Conversation

blowmage
Copy link
Contributor

A service account's issuer and signing_key values are required to generate a signed_url. Initially, all gcloud-ruby connections were service accounts, but it now supports GCE and Cloud SDK credentials as well. These new types of credentials are missing the assertion values (issuer and signing_key). In order to generate signed_urls these values need to be passed in.

[fixes #181]

Credentials from non-service account JSON files, like GCE, do not have
issuer and signing_key available. In those cases the users must pass in
the issuer and signing_key values for signed_url to work.

[refs googleapis#181]
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 21, 2015
quartzmo added a commit that referenced this pull request Jul 22, 2015
Pass issuer and signing_key when creating a signed_url
@quartzmo quartzmo merged commit 9ff6dec into googleapis:master Jul 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gcloud::Storage::File#signed_url does not work when using Google Cloud SDK credentials
3 participants