Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): send invocation_id header in all requests #19161

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

bajajneha27
Copy link
Contributor

@bajajneha27 bajajneha27 commented Sep 14, 2022

Fixes #18827
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea.
  • Follow the instructions in CONTRIBUTING. Most importantly, ensure the tests and linter pass by running bundle exec rake ci in the gem subdirectory.
  • Update code documentation if necessary.

closes: #<issue_number_goes_here>

@bajajneha27 bajajneha27 requested review from a team as code owners September 14, 2022 15:20
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Sep 14, 2022
@dazuma
Copy link
Member

dazuma commented Sep 14, 2022

Make sure this PR gets updated to include a gemspec update that requires the version of google-apis-core that adds this field to RequestOptions.

@SandeepTuniki
Copy link
Contributor

SandeepTuniki commented Sep 20, 2022

Dependency is updated in googleapis/google-api-ruby-client#11808

@nsakapeter
Copy link

nsakapeter commented Oct 17, 2022

Seems like this PR may have broken the 'google-cloud-storage' gem for Ruby. I had to upgrade the gem to ~> 1.43.0. Also if the developer had the gemlock file locked at google-apis- 0.8.0. that needs to be removed and updated a bundle install needs t run again.

NoMethodError (undefined method `add_invocation_id_header=' for #<Google::Apis::RequestOptions:0x00007fc5e6b06d10>):      |   
| google-cloud-storage (1.42.0) lib/google/cloud/storage/service.rb:67:in `initialize'
| google-cloud-storage (1.42.0) lib/google/cloud/storage.rb:114:in `new'
| google-cloud-storage (1.42.0) lib/google/cloud/storage.rb:114:in `new'
| activestorage (6.0.6) lib/active_storage/service/gcs_service.rb:138:in `client'
| activestorage (6.0.6) lib/active_storage/service/gcs_service.rb:134:in `bucket'
| activestorage (6.0.6) lib/active_storage/service/gcs_service.rb:115:in `file_for'
| activestorage (6.0.6) lib/active_storage/service/gcs_service.rb:86:in `block in url'
| activesupport (6.0.6) lib/active_support/notifications.rb:180:in `block in instrument'
| activesupport (6.0.6) lib/active_support/notifications/instrumenter.rb:24:in `instrument'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Storage] Add invocation-id to x-goog-api-client header for Ruby storage
4 participants