Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsub): split large (mod)ACK requests into smaller ones #9594

Merged
merged 3 commits into from
Nov 22, 2019

Commits on Nov 4, 2019

  1. fix(pubsub): split large (mod)ACK requests into smaller ones

    There is a server-side limit on the maximum size of ACK and modACK
    requests, which can be hit if the leaser tries to manage too many
    messages in a single requests.
    
    This commit assures that such large requests are split into multiple
    smaller requests.
    plamut committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    0c61849 View commit details
    Browse the repository at this point in the history
  2. Decrease max ACK batch size to 2500

    The previous limit of 3000 seems to be too optimistic, and the request
    size limit is still hit. Reducing the batch size to 2500 fixes the
    problem.
    plamut committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    86f1d7f View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2019

  1. Add additional test assertions about sent ACK IDs

    The tests should also check that each message is (MOD)ACK-ed exactly
    once.
    plamut committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    62f9d79 View commit details
    Browse the repository at this point in the history