Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making datastore client inherit from base client #955

Closed

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jun 26, 2015

NOTE: This has #953 as a diffbase.

@tseaver This will likely conflict with #944, it's really more of an "ideas" PR.

@dhermes dhermes added api: datastore Issues related to the Datastore API. api: core labels Jun 26, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2015
This required lots of changes since the tests assume
a client only optionally has a connection attached.
@dhermes dhermes force-pushed the client-parent-in-datastore branch from 793d7a8 to dd93c80 Compare July 21, 2015 16:33
@dhermes
Copy link
Contributor Author

dhermes commented Jul 21, 2015

@tseaver PTAL. I re-created this PR after you finished migrating datastore to the client pattern.

@tseaver
Copy link
Contributor

tseaver commented Jul 21, 2015

Crap, I was just working on this one. :(

@dhermes
Copy link
Contributor Author

dhermes commented Jul 21, 2015

What to do? Did you forget this PR existed?

@tseaver
Copy link
Contributor

tseaver commented Jul 21, 2015

I think I prefer #1004: I was able to simplify some of the testing interactions w/ the mocked connection, and reduce coupling between 'test_client' and 'test_connection'.

@tseaver
Copy link
Contributor

tseaver commented Jul 21, 2015

I didn't realize you were refreshing it. :(

@dhermes
Copy link
Contributor Author

dhermes commented Jul 21, 2015

Closing. Bowing out to #1004

@dhermes dhermes closed this Jul 21, 2015
@dhermes dhermes deleted the client-parent-in-datastore branch July 21, 2015 17:43
@tseaver
Copy link
Contributor

tseaver commented Jul 21, 2015

Sorry about that. I should've checked with you in Hangouts first.

@dhermes
Copy link
Contributor Author

dhermes commented Jul 21, 2015

No worries.

tseaver added a commit that referenced this pull request Jul 21, 2015
…ng_base

Refresh #955:  make datastore.Client derive from base client.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: core api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants