Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitoring: Allow recursive group deletion, deprecate internal checkers, add SSL validation and content match options to uptime check (via synth). #9218

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Monitoring: Allow recursive group deletion, deprecate internal checkers, add SSL validation and content match options to uptime check (via synth). #9218

merged 1 commit into from
Sep 13, 2019

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/monitoring/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:0e6f3a668cd68afc768ecbe08817cf6e56a0e64fcbdb1c58c3b97492d12418a1
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/monitoring/artman_monitoring.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/group_service.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/group_service.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/metric.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/metric.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/alert_service.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/alert_service.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/dropped_labels.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/dropped_labels.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/group.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/group.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/common.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/common.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/notification.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/notification.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/metric_service.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/metric_service.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/alert.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/alert.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/uptime_service.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/uptime_service.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/mutation_record.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/mutation_record.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/uptime.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/uptime.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/span_context.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/span_context.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/notification_service.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/notification_service.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto.
synthtool > Replaced 'def .*\\(([^\\)]+)\n.*metadata=None\\):\n\\s+"""(.*\n)*?\\s+"""\n' in google/cloud/monitoring_v3/gapic/alert_policy_service_client.py.
synthtool > Replaced 'def .*\\(([^\\)]+)\n.*metadata=None\\):\n\\s+"""(.*\n)*?\\s+"""\n' in google/cloud/monitoring_v3/gapic/metric_service_client.py.
synthtool > Replaced 'def .*\\(([^\\)]+)\n.*metadata=None\\):\n\\s+"""(.*\n)*?\\s+"""\n' in google/cloud/monitoring_v3/gapic/uptime_check_service_client.py.
synthtool > Replaced 'def .*\\(([^\\)]+)\n.*metadata=None\\):\n\\s+"""(.*\n)*?\\s+"""\n' in google/cloud/monitoring_v3/gapic/notification_channel_service_client.py.
synthtool > Replaced 'def .*\\(([^\\)]+)\n.*metadata=None\\):\n\\s+"""(.*\n)*?\\s+"""\n' in google/cloud/monitoring_v3/gapic/group_service_client.py.
synthtool > Replaced '(^.*$\\n)*' in google/cloud/monitoring_v3/proto/common_pb2.py.
synthtool > No replacements made in google/cloud/monitoring_v3/gapic/alert_policy_service_client.py for pattern then a new `\[CONDITION_ID\]` is created.
, maybe replacement is not longer needed?
synthtool > Replaced '                ::\n\n' in google/cloud/monitoring_v3/gapic/alert_policy_service_client.py.
synthtool > Replaced '^(\\s+)have an ``id`` label:  ::      resource.type =\n.*' in google/cloud/monitoring_v3/proto/metric_service_pb2.py.
synthtool > Replaced 'from google.cloud.monitoring_v3.gapic import notification_channel_service_client\n' in google/cloud/monitoring_v3/__init__.py.
synthtool > Replaced 'notification_channel_service_client.NotificationChannelServiceClient' in google/cloud/monitoring_v3/__init__.py.
.coveragerc
.flake8
MANIFEST.in
noxfile.py.j2
setup.cfg
Running session blacken
Creating virtual environment (virtualenv) using python3.6 in .nox/blacken
pip install black
black google tests docs
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/alert_policy_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/docs/conf.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/group_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/metric_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/alert_policy_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/notification_channel_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/group_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/transports/alert_policy_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/transports/group_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/transports/metric_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/transports/notification_channel_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/transports/uptime_check_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/metric_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/uptime_check_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/alert_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/notification_channel_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/alert_service_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/uptime_check_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/common_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/dropped_labels_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/dropped_labels_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/alert_service_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/group_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/group_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/group_service_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/common_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/metric_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/alert_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/metric_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/mutation_record_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/mutation_record_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/metric_service_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/notification_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/group_service_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/notification_service_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/span_context_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/span_context_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/notification_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/uptime_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/metric_service_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/notification_service_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/uptime_service_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/tests/system/gapic/v3/test_system_metric_service_v3.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/types.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/uptime_service_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/tests/unit/gapic/v3/test_alert_policy_service_client_v3.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/tests/unit/gapic/v3/test_group_service_client_v3.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/uptime_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/tests/unit/gapic/v3/test_uptime_check_service_client_v3.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/tests/unit/gapic/v3/test_metric_service_client_v3.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/tests/unit/gapic/v3/test_notification_channel_service_client_v3.py
All done! ✨ 🍰 ✨
56 files reformatted, 9 files left unchanged.
Session blacken was successful.
synthtool > Cleaned up 2 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation added the api: monitoring Issues related to the Cloud Monitoring API. label Sep 12, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 12, 2019
@tseaver tseaver changed the title [CHANGE ME] Re-generated monitoring to pick up changes in the API or client library generator. Monitoring: Allow recursive group deletion; deprecate internal checkers (via synth). Sep 12, 2019
@tseaver
Copy link
Contributor

tseaver commented Sep 12, 2019

@busunkim96 This is big, and enough like yesterday's that I don't have enough context to figure out whether the rollback you mentioned in googleapis actually happend.

@busunkim96 busunkim96 changed the title Monitoring: Allow recursive group deletion; deprecate internal checkers (via synth). Monitoring: Allow recursive group deletion, deprecate internal checkers, add SSL validation and content match options to uptime check (via synth). Sep 13, 2019
@busunkim96 busunkim96 merged commit ef3cc4a into master Sep 13, 2019
busunkim96 added a commit that referenced this pull request Sep 16, 2019
@busunkim96
Revert " Allow recursive group deletion, deprecate internal checkers,…
35ecfce 
… add SSL validation and content match options to uptime check (via synth). (#9218)"

This reverts commit ef3cc4a.
@busunkim96 busunkim96 mentioned this pull request Sep 16, 2019
Merged
busunkim96 added a commit that referenced this pull request Sep 17, 2019
@busunkim96
Revert " Allow recursive group deletion, deprecate internal checkers,…
b4ea85c 
… add SSL validation and content match options to uptime check (via synth). (#9218)" (#9234)

This reverts commit ef3cc4a.
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
@yoshi-automation @emar-kar
Allow recursive group deletion, deprecate internal checkers, add SSL…
e0d67e6 
… validation and content match options to uptime check (via synth). (googleapis#9218)
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
@busunkim96 @emar-kar
Revert " Allow recursive group deletion, deprecate internal checkers,…
749f986 
… add SSL validation and content match options to uptime check (via synth). (googleapis#9218)" (googleapis#9234)

This reverts commit ef3cc4a.
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
@yoshi-automation @emar-kar
Allow recursive group deletion, deprecate internal checkers, add SSL…
603e3aa 
… validation and content match options to uptime check (via synth). (googleapis#9218)
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
@busunkim96 @emar-kar
Revert " Allow recursive group deletion, deprecate internal checkers,…
f0b4daf 
… add SSL validation and content match options to uptime check (via synth). (googleapis#9218)" (googleapis#9234)

This reverts commit ef3cc4a.
parthea pushed a commit that referenced this pull request Oct 21, 2023
@yoshi-automation @busunkim96
Allow recursive group deletion, deprecate internal checkers, add SSL…
cab6ae4 
… validation and content match options to uptime check (via synth). (#9218)
parthea pushed a commit that referenced this pull request Oct 21, 2023
@busunkim96
Revert " Allow recursive group deletion, deprecate internal checkers,…
5461f38 
… add SSL validation and content match options to uptime check (via synth). (#9218)" (#9234)

This reverts commit 21f1a926ad2cf479e01ab75b6c0b6bb7a0c8022c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 Awaiting requested review from busunkim96

Assignees
No one assigned
Labels
api: monitoring Issues related to the Cloud Monitoring API. cla: yes This human has signed the Contributor License Agreement. codegen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yoshi-automation @tseaver @googlebot @busunkim96