Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speech: Add speaker diarization configuration support (via synth). #9202

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Speech: Add speaker diarization configuration support (via synth). #9202

merged 1 commit into from
Sep 10, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 10, 2019

Also, exclude 'noxfile.py' from synth (to preserve 'samples').

Supersedes #9196.

Also, exclude 'noxfile.py' from synth (to preserve 'samples').

Supersedes #9196.
@tseaver tseaver added api: speech Issues related to the Speech-to-Text API. codegen labels Sep 10, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 10, 2019
@tseaver
Copy link
Contributor Author

tseaver commented Sep 10, 2019

@busunkim96 This PR and #9201 assume that just excluding noxfile.py from the synth copy process is correct for language and speech (so that the samples stanza remains). Would re rather add a samples section to the generator?

The current implementation:

  • skips the stanza if the samples directory is missing;
  • tests the samples using sample-tester

@busunkim96
Copy link
Contributor

@tseaver I should probably add the samples session to the noxfile template eventually. This is fine for now.

@busunkim96 busunkim96 merged commit 7da4a40 into googleapis:master Sep 10, 2019
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 11, 2019
…s#9202)

Also, exclude 'noxfile.py' from synth (to preserve 'samples').

Supersedes googleapis#9196.
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
…s#9202)

Also, exclude 'noxfile.py' from synth (to preserve 'samples').

Supersedes googleapis#9196.
atulep pushed a commit that referenced this pull request Apr 3, 2023
Also, exclude 'noxfile.py' from synth (to preserve 'samples').

Supersedes #9196.
atulep pushed a commit that referenced this pull request Apr 6, 2023
Also, exclude 'noxfile.py' from synth (to preserve 'samples').

Supersedes #9196.
atulep pushed a commit that referenced this pull request Apr 18, 2023
Also, exclude 'noxfile.py' from synth (to preserve 'samples').

Supersedes #9196.
parthea pushed a commit that referenced this pull request Oct 22, 2023
Also, exclude 'noxfile.py' from synth (to preserve 'samples').

Supersedes #9196.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: speech Issues related to the Speech-to-Text API. cla: yes This human has signed the Contributor License Agreement. codegen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants