Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pubsub: Use kwargs in test_subscriber_client #8414

Merged
merged 2 commits into from
Jun 19, 2019
Merged

Pubsub: Use kwargs in test_subscriber_client #8414

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c44f61e
Use kwargs in test_subscriber_client
dgorelik Jun 18, 2019
26de36d
Merge pull request #1 from dgorelik/dgorelik-patch-1
dgorelik Jun 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pubsub/tests/unit/pubsub_v1/subscriber/test_subscriber_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,9 @@ def test_subscribe(manager_open):

assert future._manager._subscription == "sub_name_a"
manager_open.assert_called_once_with(
mock.ANY, mock.sentinel.callback, future.set_exception
mock.ANY,
callback=mock.sentinel.callback,
on_callback_error=future.set_exception,
)


Expand All @@ -100,5 +102,7 @@ def test_subscribe_options(manager_open):
assert future._manager.flow_control == flow_control
assert future._manager._scheduler == scheduler
manager_open.assert_called_once_with(
mock.ANY, mock.sentinel.callback, future.set_exception
mock.ANY,
callback=mock.sentinel.callback,
on_callback_error=future.set_exception,
)