Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making json.loads() optional in gcloud.exceptions.make_exception. #628

Merged
merged 1 commit into from
Feb 13, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Feb 13, 2015

Fixes #626.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 13, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c3e1351 on dhermes:fix-626 into f73ad7e on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor

tseaver commented Feb 13, 2015

LGTM

dhermes added a commit that referenced this pull request Feb 13, 2015
Making json.loads() optional in gcloud.exceptions.make_exception.
@dhermes dhermes merged commit bdc591e into googleapis:master Feb 13, 2015
@dhermes dhermes deleted the fix-626 branch February 13, 2015 18:37
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make_exception fails when json.loads fails
4 participants