Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix branch coverage for un-called callbacks. #6242

Merged
merged 1 commit into from
Oct 17, 2018
Merged

Fix branch coverage for un-called callbacks. #6242

merged 1 commit into from
Oct 17, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 17, 2018

Use mock.Mock() w/ return_value True, rather than inlining lambda _: True in cases where the callback doesn't get called.

@tseaver
Fix branch coverage for un-called callbacks.
9eea160 
Use 'mock.Mock()' w/ 'return_value' True, rather than inlining
'lambda _: True' in cases where the callback doesn't get called.
@tseaver tseaver requested a review from crwilcox October 17, 2018 19:46
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 17, 2018
@tseaver
Copy link
Contributor Author

tseaver commented Oct 17, 2018

Merging w/o review: testing only fix for broken api_core CI on master.

@tseaver tseaver merged commit 7527a4e into googleapis:master Oct 17, 2018
@tseaver tseaver deleted the 6211-api_core-fix_branch_coverage branch October 17, 2018 19:57
This was referenced Oct 17, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: core cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tseaver @googlebot