Repeating pylint after failures. #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This surfaced as a false negative in googleapis#611.
googlebot
added
the
cla: yes
|
The only issue I see here is that "real" lint failures will take twice as long, even if the envvars aren't set to try to speed the test up. |
|
But the user can always "Ctrl-C" and just go fix (if the watched pot is still boiling). If they aren't watching / waiting on the run, then the time isn't as crucial? |
|
Could we only retry on failure if we were doing a limited set to begin with? |
|
Yes, I'm happy to do that. I considered it but decided to go with the solution that involved less code. |
|
@tseaver I added a boolean indicating if a restricted fileset was used. PTAL. |
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Feb 12, 2015
Repeating pylint after failures.
vchudnov-g
pushed a commit
that referenced
this pull request
Sep 20, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This surfaced as a false negative in #611.