Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add py33 to tox. #600

Merged
merged 2 commits into from
Feb 9, 2015
Merged

Add py33 to tox. #600

merged 2 commits into from
Feb 9, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Feb 9, 2015

Fixes #152.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 9, 2015
@dhermes
Copy link
Contributor

dhermes commented Feb 9, 2015

No py33 rule exists.

@dhermes
Copy link
Contributor

dhermes commented Feb 9, 2015

Also it looks like PEP8 1.6.0 (released February 6) decided E402 module level import not at top of file is important

@tseaver
Copy link
Contributor Author

tseaver commented Feb 9, 2015

tox33 is covered by the generic [testenv] section.

#601 addresses the pep8 1.6.1 failures.

@tseaver
Copy link
Contributor Author

tseaver commented Feb 9, 2015

Rebased after merging #601.

@dhermes
Copy link
Contributor

dhermes commented Feb 9, 2015

Ahh, I didn't know that. Cool! This means we could drop [testenv:py26] right?

LGTM pending Travis

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 760f44a on tseaver:152-add_py33_to_tox into * on GoogleCloudPlatform:master*.

@tseaver
Drop fossilized '[testenv:py26]' tox environment.
a69c879 
We are now 2.6-compatible in the default environment.
@tseaver
Copy link
Contributor Author

tseaver commented Feb 9, 2015

I think the [testenv:py26] bits might be a fossil from some point in time where we needed to pin a dependency to a 2.6-compatible version (#284 maybe?). At any rate, it is now identical to [testenv], and so can go: (see a69c879).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a69c879 on tseaver:152-add_py33_to_tox into 6de4110 on GoogleCloudPlatform:master.

tseaver added a commit that referenced this pull request Feb 9, 2015
@tseaver
Merge pull request #600 from tseaver/152-add_py33_to_tox
ab0a587 
Add py33 to tox.
@tseaver tseaver merged commit ab0a587 into googleapis:master Feb 9, 2015
@tseaver tseaver deleted the 152-add_py33_to_tox branch February 9, 2015 23:17
@dhermes dhermes mentioned this pull request Feb 14, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for py33 and py34 in tox
4 participants
@tseaver @dhermes @coveralls @googlebot