Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making Bucket.delete() work in face of eventual consistency. #581

Merged
merged 1 commit into from
Feb 3, 2015
Merged

Making Bucket.delete() work in face of eventual consistency. #581

merged 1 commit into from
Feb 3, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jan 30, 2015

Fixes #564.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 30, 2015
@dhermes dhermes changed the title Making Bucket.delete() work in face on eventual consistency. Making Bucket.delete() work in face of eventual consistency. Jan 30, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0543a2f on dhermes:storage-fix-564 into d858ff0 on GoogleCloudPlatform:master.

@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Jan 31, 2015
@dhermes dhermes mentioned this pull request Jan 31, 2015
Merged
tseaver
tseaver reviewed Feb 3, 2015
View reviewed changes
gcloud/storage/bucket.py
max_results=self._MAX_OBJECTS_FOR_BUCKET_DELETE + 1))
if len(blobs) > self._MAX_OBJECTS_FOR_BUCKET_DELETE:
raise ValueError('Refusing to delete bucket with more than '
'256 objects. If you actually want to delete '

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor

tseaver commented Feb 3, 2015

Other than my quibble about the error message, LGTM.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 85c64a3 on dhermes:storage-fix-564 into 4f29529 on GoogleCloudPlatform:master.

dhermes added a commit that referenced this pull request Feb 3, 2015
@dhermes
Merge pull request #581 from dhermes/storage-fix-564
32b7853 
Making Bucket.delete() work in face of eventual consistency.
@dhermes dhermes merged commit 32b7853 into googleapis:master Feb 3, 2015
@dhermes dhermes deleted the storage-fix-564 branch February 3, 2015 17:53
@dhermes
Copy link
Contributor Author

dhermes commented Feb 3, 2015

@tseaver I folded your comment into the original commit during a rebase. Thanks.

vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@release-please
chore(main): release 2.16.0 (#581)
ba87cb6 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
build(deps): [autoapprove] bump certifi from 2022.12.7 to 2023.7.22 (#…
4f2ed49 
…581)

Source-Link: googleapis/synthtool@395d53a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6c1cbc75c74b8bdd71dada2fa1677e9d6d78a889e9a70ee75b93d1d0543f96e1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Bucket.delete() in storage more restricted / opinionated
4 participants
@dhermes @coveralls @tseaver @googlebot