Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding implicit dataset ID support for GAE and GCE. #572

Merged

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jan 27, 2015

Fixes #475

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 27, 2015
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6267857 on dhermes:add-gae-gce-support-for-implicit-id into * on GoogleCloudPlatform:master*.

@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Jan 27, 2015


def app_engine_id():
"""Gets the App Engine application ID if it can be implied.

This comment was marked as spam.

@dhermes dhermes force-pushed the add-gae-gce-support-for-implicit-id branch from 6267857 to c3286a2 Compare January 27, 2015 22:19
@dhermes
Copy link
Contributor Author

dhermes commented Jan 27, 2015

@tseaver I addressed the vocab changes (incorporated them into the original commits) and rebased on top of current master.

LGTY?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c3286a2 on dhermes:add-gae-gce-support-for-implicit-id into 6bbb144 on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor

tseaver commented Jan 27, 2015

LGTM

dhermes added a commit that referenced this pull request Jan 27, 2015
Adding implicit dataset ID support for GAE and GCE.
@dhermes dhermes merged commit 50f0684 into googleapis:master Jan 27, 2015
@dhermes dhermes deleted the add-gae-gce-support-for-implicit-id branch January 27, 2015 23:20
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
Source-Link: googleapis/synthtool@50db768
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e09366bdf0fd9c8976592988390b24d53583dd9f002d476934da43725adbb978
parthea pushed a commit that referenced this pull request Oct 21, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GAE/GCE support for datastore.set_default_dataset and add exception on failure
4 participants